Update compatibility to 4.0-stable

[Beliar83]

This makes godex compile with commit 92bee43adba8d2401ef40e2480e53087bcb1eaf1, which is the one that was used to build the stable reelase of Godot 4.0.

I am not 100% if the function I wrote to replace remove_and_skip is working correctly. I did some quick tests and it looks okay, but maybe someone with a deeper knowledge of godex should double check.

[Beliar83]

I have added changes for compatibility for up to 4.0 rc1.
I also added a fix for register_runtime_scripts that does not need a godot change.

[Beliar83]

@RevoluPowered Where exactly are the extra whitespaces? Or is there one missing?

[mkay-dev]

This makes godex compile with commit 92bee43adba8d2401ef40e2480e53087bcb1eaf1, which is the one that was used to build the stable reelase of Godot 4.0.

Please continue updating Godex while Andrea Catania is busy. There seem to be new issues with compilation due to the following Godot commit godotengine/godot@4e34cf2 .

[Beliar83]

@mkay-dev Ah, I guess that was the error on the build I got earlier. I'll try to check that when I am home later today.

[mkay-dev]

@Beliar83 Thanks in advance. Can I maybe also motivate you to fix some linux issues should they arise. I'm not yet deeply familiar with c++ and godot/godexs source code so I'm only working up to fixing these kind of issues myself.

[Beliar83]

@mkay-dev It should generally build on linux (the automatic builds in my fork and this PR do), though I have WSL or a VM at best. If you have any specific problem I can look at it, though.

[mkay-dev]

@Beliar83 Sounds great. Your fork did compile against Godots 4.0 release build just fine so I'm just being heedful of possible issues. Again thanks for the help.

[mkay-dev]

Here is the compilation error I am getting:

[ 7%] Generating modules tests header.
[ 26%] Compiling modules/gdscript/gdscript_byte_codegen.cpp ...
[ 26%] Compiling tests/test_main.cpp ...
[ 26%] Compiling modules/gdscript/gdscript_cache.cpp ...
[ 26%] Compiling modules/gdscript/gdscript_compiler.cpp ...
In file included from /home/mkay/projects/godot/from_scratch/modules/godex/tests/test_ecs_pipeline_builder.h:14,
from ./modules/modules_tests.gen.h:12,
from tests/test_main.cpp:113:
/home/mkay/projects/godot/from_scratch/modules/godex/tests/test_utilities.h: In function 'bool register_ecs_script(const StringName&, const String&)':
/home/mkay/projects/godot/from_scratch/modules/godex/tests/test_utilities.h:32: warning: comparison with string literal results in unspecified behavior [-Waddress]
32 | if (extends == "System") {
|
/home/mkay/projects/godot/from_scratch/modules/godex/tests/test_utilities.h:32: error: comparison between distinct pointer types 'GDScriptParser::IdentifierNode*' and 'const char*' lacks a cast [-fpermissive]
[ 26%] Compiling modules/gdscript/gdscript_disassembler.cpp ...
scons: *** [tests/test_main.linuxbsd.editor.x86_64.o] Error 1
scons: building terminated because of errors.
[Time elapsed: 00:00:38.732]

[Beliar83]

@mkay-dev I reset my fork and worked on a separate branch for updating the compatibility - as I should have done from the start, so there was nothing changed yet for this PR. I have fixed the problem, but I am doing one more check build after merging from this repo.

[mkay-dev]

@Beliar83 Excellent! You're a true hero.
Seems to be compiling fine for now. Only had to add missing #include "utility" in /modules/godex/tests/test_ecs_storage_hierarchical.h and /modules/godot/nodes/ecs_world.cpp as I was getting:

error: 'as_const' is not a member of 'std'; did you mean 'is_const'?

[fire]

Typically godot engine developers do one merge commit (rebase and then force push to a feature branch). What does @AndreaCatania prefer and how far is this from working?

[fire]

Godot 4.1-stable released a few days ago.

[fire]

https://github.com/Beliar83/godex/blob/main/systems/system.h#L6 is using the wrong type of include.

#include "../ecs_types.h"

[Beliar83]

Yeah, I have already updated it in https://github.com/Beliar83/godex/tree/dev_main

[YPares]

Hi! Is the work on that PR still going on?

[AndreaCatania]

Hi @YPares, I don't think so.

[YPares]

Oh :/ ok. That's too bad...

[Beliar83]

@YPares If you mean whether I still do updates, then no.

[fire]

If there is still interest we'll probably need to fork the repository and start merging changes.

[AndreaCatania]

This is a good idea @fire

[fire]

@AndreaCatania since you're here, you could give maintainer ship to interested people wanting to maintain godex

[AndreaCatania]

Hey @fire, fork the project is the way to go, at least for the moment