Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable shell-related and env var tests Windows already supports #1845

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Enable shell-related and env var tests Windows already supports #1845

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e451d0
Fix and enable disallow_shell test on Windows
EliahKagan Feb 17, 2025
4fc1092
Test environment_variables_are_passed_one_by_one on Windows
EliahKagan Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions gix-command/tests/command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,6 @@ mod spawn {
use bstr::ByteSlice;

#[test]
#[cfg(unix)]
fn environment_variables_are_passed_one_by_one() -> crate::Result {
let out = gix_command::prepare("echo $FIRST $SECOND")
.env("FIRST", "first")
Expand All @@ -459,10 +458,9 @@ mod spawn {
}

#[test]
#[cfg(unix)]
fn disallow_shell() -> crate::Result {
let out = gix_command::prepare("PATH= echo hi")
.command_may_be_shell_script()
.command_may_be_shell_script_disallow_manual_argument_splitting()
.spawn()?
.wait_with_output()?;
assert_eq!(out.stdout.as_bstr(), "hi\n");
Expand Down
Loading