Enable shell-related and env var tests Windows already supports #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EliahKagan
changed the title
Byron
approved these changes
Feb 17, 2025
Sorry about that, I just forgot to mark it ready for review! (My internet connection cut out for a bit and I forgot to come back to this to check the CI results.) Edit: I've rebased, to make the history easier for me to visualize while working on related code, but there are no other changes. |
The `disallow_shell` test case for `gix-command` has two parts. The first part runs a command that would fail if not really run in a shell, mostly to verify that the second part of the test is robust enough. The second part actually tests the `Prepare::without_shell` method. While neither part should be made any less robust, only the first part had failed on Windows, and the reason was (or had become) only that it would not really run in a shell, due to being eligible for manual argument splitting and `allow_manual_arg_splitting` being `true` by default on Windows. Therefore, this modifies the first part to use a method that sets `allow_manual_arg_splitting` to `false`. This is sufficient to make the test pass on Windows, so this also enables it on all platforms.
This enables the `environment_variables_are_passed_one_by_one` test for `gix-command` on Windows. It was marked to run on Unix-like systems only. But it runs and passes on Windows, requiring no changes. (Possibly it hadn't passed at the time it was introduced.) The `command_may_be_shell_script` call is sufficient even though it does not disable manual argument splitting, because the command used in this test contains `$` (to expand variables in the shell) and is thus already ineligible for manual argument splitting.
EliahKagan
force-pushed
the
shell-tests-windows
branch
from
d4c5aa0 to
4fc1092
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables two
gix-commandtests on Windows that had previously only run on Unix-like systems. One required a small change that didn't affect the robustness of the test, while the other required no change. Full details are in the commit messages.