various fixes #1835
Merged
various fixes #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logs (#1829) Previously it would retrieve the configured committer, or trigger an error if there was none despite the commiter being provided to `commit_as()`. This als adds `Repository::edit_references_as(committer)` to allow passing a given committer.
…section_filter()` (#1826) The underlying issue isn't fixed, as ids in the lookup table remain even after deletion. However, for now it was easiest to defensively access this data, while assuring that the API (still) does what it claims.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
commit_asdoes not forward the given committer information #1829gix::config::File::remove_section_filter#1826