Skip to content

refactor(core): migrate DeepReview runtime ownership#1132

Merged
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/refactor-m15-deepreview-execution
Jun 10, 2026
Merged

refactor(core): migrate DeepReview runtime ownership#1132
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/refactor-m15-deepreview-execution

Conversation

@limityan

@limityan limityan commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Move DeepReview provider-neutral queue timing, capacity decisions, retry/backoff state, result shaping, diagnostics formatting, incremental cache selection, and cache-hit/cache-miss report signal shaping into bitfun-agent-runtime.
  • Simplify core TaskTool / CodeReviewTool paths so core keeps product-context side effects: launch, event emission, queue sleeping, session metadata IO, persistence, and product Tool adapters.
  • Delete the old core queue timing module and duplicate core-side DeepReview cache/packet tests; runtime now owns the behavior coverage.
  • Extend core-boundary rules and self-tests to prevent migrated DeepReview task-execution, report, and cache ownership from flowing back into core.
  • Update the core decomposition plan/completed notes for the migrated DeepReview runtime owner scope.

Compatibility and risk

  • No Cargo dependency changes.
  • Existing core compatibility exports are preserved for old DeepReview policy paths.
  • User-visible DeepReview behavior is intended to remain unchanged: queue status, retry guidance, capacity skip payloads, cached reviewer results, and report reliability signals keep their existing shapes.
  • Core still owns concrete side effects that need product context: session metadata, persistence IO, event emission, queue sleeping, task launch, and provider invocation.

Verification

  • cargo test -p bitfun-agent-runtime deep_review::report --lib
  • cargo test -p bitfun-agent-runtime deep_review::task_execution --lib
  • cargo test -p bitfun-core --features product-full deep_review --lib
  • node --test scripts/check-core-boundaries.test.mjs
  • node scripts/check-core-boundaries.mjs
  • cargo check -p bitfun-core --no-default-features
  • cargo check --workspace
  • cargo metadata --no-deps --format-version 1
  • pnpm run check:repo-hygiene
  • git diff --check

@limityan limityan force-pushed the yanzhn/refactor-m15-deepreview-execution branch from c7da6e1 to a88821b Compare June 10, 2026 08:05
@limityan limityan force-pushed the yanzhn/refactor-m15-deepreview-execution branch from a88821b to 0a9be3f Compare June 10, 2026 09:00
@limityan limityan force-pushed the yanzhn/refactor-m15-deepreview-execution branch from 0a9be3f to 5d3009e Compare June 10, 2026 09:38
@limityan limityan merged commit efbf5ec into GCWing:main Jun 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant