Skip to content

Commit efbf5ec

Browse files
committed
refactor(core): migrate DeepReview runtime ownership
1 parent 3241ddb commit efbf5ec

14 files changed

Lines changed: 2250 additions & 966 deletions

File tree

docs/plans/core-decomposition-completed.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
### 1.4 Agent Runtime、Harness 与 Product Domain
3838

39-
- `agent-runtime` 已承接 scheduler/background delivery 纯决策、turn outcome lifecycle plan、thread goal runtime、subagent visibility、prompt cache facts、prompt environment facts、mode/source presentation facts、scheduled-job lifecycle state、custom subagent schema/default/markdown IO/discovery/loading、post-call hook routing、tool confirmation plan、goal/user-question tool wire contract、SessionControl 输入契约、部分 event fact 映射、DeepResearch citation renumber 纯重排逻辑,以及 DeepReview policy / manifest / budget / queue / report enrichment / incremental cache / shared-context runtime state / task-execution provider-neutral packet、retry、backoff、capacity-skip shaping、provider capacity error decisionprovider/admission queue step decision。
39+
- `agent-runtime` 已承接 scheduler/background delivery 纯决策、turn outcome lifecycle plan、thread goal runtime、subagent visibility、prompt cache facts、prompt environment facts、mode/source presentation facts、scheduled-job lifecycle state、custom subagent schema/default/markdown IO/discovery/loading、post-call hook routing、tool confirmation plan、goal/user-question tool wire contract、SessionControl 输入契约、部分 event fact 映射、DeepResearch citation renumber 纯重排逻辑,以及 DeepReview policy / manifest / budget / queue / report enrichment / incremental cache / shared-context runtime state / task-execution provider-neutral packet、retry、backoff、capacity-skip shaping、provider capacity error decisionprovider/admission queue step decision、provider/reviewer queue wait timing 状态机、provider retry attempt/elapsed 状态机、runtime tracker reliability signal shaping、runtime diagnostics log shaping 和 TaskTool retry/cancelled/result presentation
4040
- core 仍保留 concrete session manager、metadata/persistence IO、scheduler lifecycle、event emitter、permission UI/channel wait、concrete prompt assembly 主体、DeepReview task launch / provider wait side effect / report persistence、product `Tool` adapter 和具体 hook side effect;DeepResearch report 文件 IO / post-turn hook 已委托 `services-integrations`
4141
- `harness` 已建立 workflow descriptor、legacy route plan、provider registry,并注册 Deep Review、DeepResearch、MiniApp 的 legacy-facade provider;当前只证明 route/descriptor 边界,不代表 concrete workflow execution 已迁移。
4242
- `product-domains` 已承接 MiniApp 纯状态、storage shape、runtime detection policy、worker capacity / idle / LRU policy、host method、`fs.*` / `shell.exec` host call plan、built-in bundle identity / seed-plan facts / marker wire format、create/update/draft/apply/customization workflow 持久化顺序、import bundle planning、function-agent prompt / parser / response policy / ports,以及部分 function-agent Git snapshot/fallback 逻辑。MiniApp host dispatch、built-in seed/marker filesystem IO、JS worker process/pool lifecycle、storage filesystem IO 和 import bundle IO 已委托 `services-integrations`
@@ -58,7 +58,7 @@
5858
- boundary check 覆盖 remote-connect command routing owner,要求 core 委托 `services-integrations`,并阻止 response assembly / command policy 回流 core。
5959
- boundary check 覆盖 Bash shell helper owner,要求 core 委托 `tool-runtime::shell`,并阻止输出渲染、background result 文本、命令包装和 guard 策略回流 core。
6060
- boundary check 覆盖本地 workspace search owner,要求 core search facade 委托 `services-integrations::workspace_search`,并阻止 flashgrep session、scan fallback、preview/result conversion 和 path normalization 回流 core;remote SSH search 纯策略与 concrete owner 由 `services-integrations::remote_ssh::workspace_search` 承接。
61-
- boundary check 覆盖 tool truncation recovery presentation、confirmation wait-result、light checkpoint summary、batching plan、retry policy、DeepReview task-execution 纯策略、provider capacity error decision、provider/admission queue step decision、DeepResearch citation renumber 纯重排 owner 和 MiniApp manager workflow facade owner,要求 core tool pipeline / tool context / DeepReview task adapter / DeepResearch citation hook / MiniApp manager 委托 `bitfun-agent-tools``bitfun-agent-runtime``tool-runtime::pipeline``bitfun-product-domains`
61+
- boundary check 覆盖 tool truncation recovery presentation、confirmation wait-result、light checkpoint summary、batching plan、retry policy、DeepReview task-execution 纯策略、provider capacity error decision、provider/admission queue step decision、provider retry attempt/elapsed 状态机、TaskTool retry/cancelled/result presentation、DeepResearch citation renumber 纯重排 owner 和 MiniApp manager workflow facade owner,要求 core tool pipeline / tool context / DeepReview task adapter / DeepResearch citation hook / MiniApp manager 委托 `bitfun-agent-tools``bitfun-agent-runtime``tool-runtime::pipeline``bitfun-product-domains`
6262
- DeepReview 路径分类按六层物理 crate 解析,避免把同层多个 crate 合并成一个风险 area。
6363
- focused baseline 已覆盖 tool manifest、GetToolSpec、execution admission、MiniApp storage / builtin asset、remote workspace fallback、MCP config/catalog、agent-runtime prompt cache、custom subagent、thread-goal tools、AskUserQuestion、DeepReview hook measurement、tool confirmation、product capability pack、session restore、local/remote tool IO helper、function-agent Git、scheduled-job state 等路径。
6464

@@ -67,5 +67,5 @@
6767
- `bitfun-core` 仍是完整产品 runtime 组装点,不能声称已经退化为纯 compatibility facade。
6868
- 产品入口仍主要通过 `bitfun-core/product-full` 获取完整能力;Product Assembly 已可表达当前完整能力集合,但尚未真正按交付形态裁剪 default feature / dependency。
6969
- concrete session manager、scheduler lifecycle、event delivery、permission UI/channel wait、prompt assembly、session persistence IO、AI client factory / provider acquisition 仍在 core。
70-
- Bash tool orchestration 的可复用 shell helper、本地 indexed workspace search owner、remote workspace search concrete owner、remote SSH/SFTP/PTY concrete owner、tool confirmation/checkpoint 纯策略、tool pipeline batching/retry policy、DeepReview provider-neutral policy/report/cache/task-execution shaping、provider capacity error decision、provider/admission queue step decision、DeepResearch citation renumber 纯重排 / report IO、MiniApp host dispatch、MiniApp built-in seed/marker IO、MiniApp JS worker process/pool lifecycle、MiniApp storage filesystem IO、MiniApp import bundle IO、MiniApp import bundle planning、MiniApp manager create/update/draft/apply/customization workflow 持久化顺序和 prompt environment facts 已迁出;permission UI/channel side effect、tool pipeline concrete state/cancellation/scheduler glue、DeepReview concrete launch/provider wait side effect/report persistence,以及 MiniApp compile/path/import IO 等产品编排仍未完成 owner 迁移。
70+
- Bash tool orchestration 的可复用 shell helper、本地 indexed workspace search owner、remote workspace search concrete owner、remote SSH/SFTP/PTY concrete owner、tool confirmation/checkpoint 纯策略、tool pipeline batching/retry policy、DeepReview provider-neutral policy/report/cache/task-execution shaping、provider capacity error decision、provider/admission queue step decision、provider/reviewer queue wait timing 状态机、provider retry attempt/elapsed 状态机、runtime tracker reliability signal shaping、runtime diagnostics log shaping、TaskTool retry/cancelled/result presentation、DeepResearch citation renumber 纯重排 / report IO、MiniApp host dispatch、MiniApp built-in seed/marker IO、MiniApp JS worker process/pool lifecycle、MiniApp storage filesystem IO、MiniApp import bundle IO、MiniApp import bundle planning、MiniApp manager create/update/draft/apply/customization workflow 持久化顺序和 prompt environment facts 已迁出;permission UI/channel side effect、tool pipeline concrete state/cancellation/scheduler glue、DeepReview concrete launch/provider wait side effect/report persistence,以及 MiniApp compile/path/import IO 等产品编排仍未完成 owner 迁移。
7171
- no-default 与 product-full 的依赖边界已有数据基线,且 no-default 已不再携带 workspace-search owner、debug ingest HTTP server、AI provider adapter runtime 或 `reqwest` direct dependency;remote-ssh 基础 workspace identity 仍是兼容期依赖,不能声称各交付形态已达到最小依赖。

docs/plans/core-decomposition-plan.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
- `bitfun-core --no-default-features` 已不再携带 workspace-search owner、debug ingest HTTP server、AI provider adapter runtime 或 `reqwest` direct dependency;workspace search 旧路径、debug ingest、CLI credential acquisition 和 AI client runtime 只在显式 product feature 下组装。remote-ssh 基础 workspace identity 仍作为兼容期依赖保留,后续若要继续裁剪必须先完成 session / workspace identity 接口迁移。
2525
- `runtime-services` 已有 typed builder、capability availability 和 core product runtime provider adapter,但不少 concrete provider 仍在 core 创建或持有。
2626
- remote-connect command routing、wire response assembly、workspace/session/poll/file/dialog/cancel/interaction helper 和 state tracker contract 已归入 `services-integrations`;core 保留 host adapter、加密入口和全局 tracker 接线。
27-
- `tool-contracts` 已承接 provider-neutral tool manifest、admission、catalog、result policy、tool execution presentation 和截断恢复提示等纯策略;`tool-execution` 已承接低层 IO/search helper、Bash shell 可复用策略、结果渲染、tool pipeline batching plan 与 retry policy;`services-integrations` 已承接本地 indexed workspace search service owner、crate-private flashgrep protocol internals、remote SSH search 纯策略、remote workspace search concrete owner、remote SSH/SFTP/PTY concrete owner、DeepResearch report IO、MiniApp host dispatch、built-in seed/marker IO、MiniApp JS worker process/pool owner、MiniApp storage filesystem IO 和 MiniApp import bundle IO;`product-domains` 已承接 MiniApp create/update/draft/apply/customization workflow 持久化顺序与 import bundle planning;`agent-runtime` 已承接 tool confirmation plan/failure/wait-result、light checkpoint summary policy、prompt environment facts、DeepReview task-execution provider-neutral shaping、provider capacity error decision、provider/admission queue step decision 和 DeepResearch citation renumber 纯重排。permission UI channel side effect、tool pipeline concrete state/cancellation/scheduler glue、DeepReview concrete launch/provider wait side effect/report persistence 和完整 execution pipeline owner 仍未完全迁移。
27+
- `tool-contracts` 已承接 provider-neutral tool manifest、admission、catalog、result policy、tool execution presentation 和截断恢复提示等纯策略;`tool-execution` 已承接低层 IO/search helper、Bash shell 可复用策略、结果渲染、tool pipeline batching plan 与 retry policy;`services-integrations` 已承接本地 indexed workspace search service owner、crate-private flashgrep protocol internals、remote SSH search 纯策略、remote workspace search concrete owner、remote SSH/SFTP/PTY concrete owner、DeepResearch report IO、MiniApp host dispatch、built-in seed/marker IO、MiniApp JS worker process/pool owner、MiniApp storage filesystem IO 和 MiniApp import bundle IO;`product-domains` 已承接 MiniApp create/update/draft/apply/customization workflow 持久化顺序与 import bundle planning;`agent-runtime` 已承接 tool confirmation plan/failure/wait-result、light checkpoint summary policy、prompt environment facts、DeepReview task-execution provider-neutral shaping、provider capacity error decision、provider/admission queue step decision、provider/reviewer queue wait timing 状态机、provider retry attempt/elapsed 状态机、runtime tracker reliability signal shaping、runtime diagnostics log shaping、TaskTool retry/cancelled/result presentation 和 DeepResearch citation renumber 纯重排。permission UI channel side effect、tool pipeline concrete state/cancellation/scheduler glue、DeepReview concrete launch/provider wait side effect/report persistence 和完整 execution pipeline owner 仍未完全迁移。
2828
- `agent-stream` 已承接统一 stream DTO、tool-call 累积和 replay 契约;provider SSE / 响应解析测试归属 `ai-adapters`
2929
- `harness` 当前主要承接 descriptor / route plan / registry contract;Deep Review、DeepResearch、MiniApp 的 concrete workflow execution 仍在 core 或产品路径。
3030
- `product-domains` 已承接 MiniApp / function-agent 的部分纯领域逻辑;MiniApp storage shape、host call plan、seed-plan facts、marker wire format、worker capacity / idle / LRU policy、create/update/draft/apply/customization workflow 持久化顺序和 import bundle planning 已保持领域归属。MiniApp compile、path adaptation、import metadata/bundle IO、AI acquisition 和更大 concrete workflow execution 仍保留在 core 或 services 路径。
@@ -49,7 +49,7 @@ terminal lifecycle、concrete workflow execution、scheduler/session side effect
4949

5050
| 阶段 | 目标 | 准出标准 |
5151
|---|---|---|
52-
| M11 Concrete owner 深迁移收口 | 已迁出 remote SSH/SFTP/PTY concrete owner、DeepResearch report IO、MiniApp host dispatch、built-in seed/marker IO、MiniApp JS worker process/pool owner、MiniApp storage filesystem IO、MiniApp import bundle IO、MiniApp import bundle planning、MiniApp manager create/update/draft/apply/customization workflow 持久化顺序、DeepReview provider capacity error decisionprovider/admission queue step decision;剩余只保留需要单独接口设计的 DeepReview launch/provider wait side effect/report persistence、scheduler/event/session side effect、tool pipeline concrete state/cancellation/scheduler glue,以及 MiniApp compile/path/import IO 等仍需由 core 或 services 承接的产品编排 | 每个已迁 concrete owner 有 focused behavior tests 和 boundary anchors;不改变权限、事件、session、remote、MiniApp 或 terminal 可见行为;剩余高风险项不得无设计确认硬迁 |
52+
| M11 Concrete owner 深迁移收口 | 已迁出 remote SSH/SFTP/PTY concrete owner、DeepResearch report IO、MiniApp host dispatch、built-in seed/marker IO、MiniApp JS worker process/pool owner、MiniApp storage filesystem IO、MiniApp import bundle IO、MiniApp import bundle planning、MiniApp manager create/update/draft/apply/customization workflow 持久化顺序、DeepReview provider capacity error decisionprovider/admission queue step decision、provider/reviewer queue wait timing 状态机、provider retry attempt/elapsed 状态机、runtime tracker reliability signal shaping、runtime diagnostics log shaping 和 TaskTool retry/cancelled/result presentation;剩余只保留需要单独接口设计的 DeepReview launch/provider wait side effect/report persistence、scheduler/event/session side effect、tool pipeline concrete state/cancellation/scheduler glue,以及 MiniApp compile/path/import IO 等仍需由 core 或 services 承接的产品编排 | 每个已迁 concrete owner 有 focused behavior tests 和 boundary anchors;不改变权限、事件、session、remote、MiniApp 或 terminal 可见行为;剩余高风险项不得无设计确认硬迁 |
5353
| M12 Product shape / feature trimming / Core facade 收口 | 基于 capability matrix 裁剪 no-default/product-full 和不同交付形态依赖,并将 `bitfun-core` 限定为 compatibility facade、product-full assembly 与少量迁移期 adapter | cargo metadata / cargo tree 有对比数据;各产品形态关键入口验证通过;边界脚本阻止 owner 逻辑回流 |
5454

5555
## 5. 固定执行流程

0 commit comments

Comments
 (0)