Skip to content

Update test file for #5405 #5446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 1, 2025
+11 −8
Merged

Update test file for #5405 #5446

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0eb1a4b
Update test file for #5405
JacksonJang Nov 30, 2025
8ee4131
Remove expected-failure annotation
cowtowncoder Dec 1, 2025
ac8c6f8
Move test from under tofix
cowtowncoder Dec 1, 2025
ac29a4a
Move test back under "tofix"
cowtowncoder Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/test/java/tools/jackson/databind/tofix/MapFormatShape5405Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,25 +62,28 @@ public Bean5405Override(int value) {
}

/*
/**********************************************************
/**********************************************************************
/* Test methods, serialization
/**********************************************************
/**********************************************************************
*/

final private ObjectMapper MAPPER = newJsonMapper();
private final ObjectMapper MAPPER = newJsonMapper();

// Can't yet use per-property overrides at all, see [databind#5405]
// [databind#5045]: property overrides for @JsonFormat.shape won't work for Maps
// 30-Nov-2025, tatu: Something about caching is the issue: if "b" commented out,
// override appears to work; with "b" not
@JacksonTestFailureExpected
@Test
public void testSerializeAsPOJOViaProperty() throws Exception
public void serializeAsPOJOViaProperty() throws Exception
{
String result = MAPPER.writeValueAsString(new Bean5405Container(1,0,3));
assertEquals(a2q("{'a':{'extra':13,'empty':false},'c':{'empty':false,'value':3}}"),
String result = MAPPER.writeValueAsString(new Bean5405Container(1,2,3));
assertEquals(a2q(
"{'a':{'extra':13,'empty':false},'b':{'value':2},'c':{'extra':13,'empty':false}}"),
result);
}

@Test
public void testSerializeNaturalViaOverride() throws Exception
public void serializeNaturalViaOverride() throws Exception
{
String result = MAPPER.writeValueAsString(new Bean5405Override(123));
assertEquals(a2q("{'stuff':{'value':123}}"),
Expand Down