Update test file for #5405 #5446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Good catch @JacksonJang ! I played with test a bit and while with "a" and "c" test passes, adding "b" it once again fails: I think there's something wrong with either caching, or missing from contextualization. Either way I'll merge improved test that reproduces real problem instead of original broken test. |
Contributor
Author
|
Thanks for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #5405,
I think the behavior should pass as tested below.
Since it's in POJO mode, the Map entries aren’t being serialized, so I updated the code accordingly.
If my updated test is correct, then the issue will be almost fully resolved.