Skip to content

Issue 2761 #2762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2020
Merged

Issue 2761 #2762

merged 2 commits into from
Jul 11, 2020

Conversation

swayamraina
Copy link
Contributor

@swayamraina swayamraina commented Jun 12, 2020

To implement #2761

  • add json key mapping to serializer
  • add test cases to verify correctness

1. only names in all sub-types
2. 'names' for multi-keys while 'name' for singular keys
@swayamraina
Copy link
Contributor Author

This PR has a dependency on the jackson-annotation PR : FasterXML/jackson-annotations#172
Post merge, new package has to be released and referenced in the new pom.

@cowtowncoder
Copy link
Member

Looks good, and would be happy to merge. Just one more thing: before the first contribution, I would need filled Contributor License Agreement (CLA), from here (apologies if I have already asked for one & received, I tried to check but did not find one):

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the usual method is to print it, fill & sign, scan/photo, email to info at fasterxml dot com.
Once I get that I can merge the annotations PR as well as this one: CLA works for these and all future contributions.

Looking forward to merging this!

@swayamraina
Copy link
Contributor Author

Looks good, and would be happy to merge. Just one more thing: before the first contribution, I would need filled Contributor License Agreement (CLA), from here (apologies if I have already asked for one & received, I tried to check but did not find one):

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the usual method is to print it, fill & sign, scan/photo, email to info at fasterxml dot com.
Once I get that I can merge the annotations PR as well as this one: CLA works for these and all future contributions.

Looking forward to merging this!

submitted

@cowtowncoder cowtowncoder merged commit da97396 into FasterXML:master Jul 11, 2020
cowtowncoder pushed a commit that referenced this pull request Jul 11, 2020
Implement #2761 (support multiple type names for `@JsonSubtypes.Type`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants