Skip to content

Support multiple names in JsonSubType.Type #2761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
swayamraina opened this issue Jun 12, 2020 · 6 comments
Closed

Support multiple names in JsonSubType.Type #2761

swayamraina opened this issue Jun 12, 2020 · 6 comments
Milestone

Comments

@swayamraina
Copy link
Contributor

swayamraina commented Jun 12, 2020

This issue is linked to FasterXML/jackson-annotations#171

@swayamraina
Copy link
Contributor Author

link to PR : #2762

@cowtowncoder
Copy link
Member

PR looks good; added note on #2762 wrt CLA.

cowtowncoder pushed a commit that referenced this issue Jul 11, 2020
Implement #2761 (support multiple type names for `@JsonSubtypes.Type`)
@cowtowncoder cowtowncoder added this to the 2.12.0 milestone Jul 11, 2020
cowtowncoder pushed a commit that referenced this issue Jul 11, 2020
Implement #2761 (support multiple type names for `@JsonSubtypes.Type`)
cowtowncoder added a commit that referenced this issue Jul 11, 2020
@cowtowncoder
Copy link
Member

@swayamraina I finally got this all merged: thank you very much for this contribution! It will be included in 2.12.0 release.

@swayamraina
Copy link
Contributor Author

@cowtowncoder should I also raise an issue to remove the singular version of this field to be removed in 3.0.0?

@cowtowncoder
Copy link
Member

I thought about that, and it would otherwise make sense but I am planning to keep 2.x and 3.x annotations compatible -- so that unlike all other components, you can actually use either one.
That is, 2.x annotations will work with 3.x and vice versa: so there is no major version difference for annotations. This is based on my experiences with 1.x -> 2.x upgrade where the only recurring issue users have is that with auto-completion they sometimes gets Jackson 1.x annotations which will not work with 2.x.

So at this point I think this sub-optimality can live on. Thank you for suggesting it though, it is good to follow up properly with clean up, keeping codebase as tidy as possible.

@swayamraina
Copy link
Contributor Author

sure, this also makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants