Skip to content

Fix JsonParser.isNaN() to be stable, only indicate explicit NaN values; not ones due to coercion #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2023

Conversation

cowtowncoder
Copy link
Member

@cowtowncoder cowtowncoder commented Dec 2, 2023

First part of fixes related to problems with number Overflow/Underflow for Double leading to problems with BigDecimal access. Second part of solution will be #1149.

@cowtowncoder
Copy link
Member Author

@pjfanning I think that this first part should help a bit: we'll simply keep track of input that is NaN and not consider possible Overflow/Underflow-induced cases actual NaNs (since they would be decodable into BigDecimal).
This allows some changes, but more importantly if this goes cleanly, can implement #1149.

/cc @JooHyukKim

@cowtowncoder cowtowncoder merged commit b67bd63 into 2.17 Dec 2, 2023
@cowtowncoder cowtowncoder deleted the tatu/2.17/1137-improve-is-nan branch December 2, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant