fix 55705 LHN - user name disappear from ws rooms admins #55974

Kalydosos · 2025-01-29T16:57:21Z

Explanation of Change

Fixed Issues

$ 55705
PROPOSAL: #55705 (comment)

Tests

Prerequisite: Have two different accounts opened in two different devices or environments.

Switch to User A account.
Tap on "Settings" and select "Workspaces"
Open any workspace and make sure its admins room is pinned
tap on "Members"
Tap on "Invite Member"
Invite User B to workspace.
Switch to User B account.
Leave the workspace.
Switch to User A account.
Check the message displayed on Admins room on LHN.
Open the room and return to LHN.
Check again the message displayed on room preview.
Verify that user B name is displayed as having left the WS in LHN
Verify that user B email or phone number is displayed as having left the WS in the admins room.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_mweb.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_mweb_safari.mp4

MacOS: Chrome / Safari

ios_web_safari.mp4

MacOS: Desktop

macos_desktop.mp4

melvin-bot · 2025-01-29T16:57:27Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Kalydosos · 2025-01-30T05:04:27Z

@rushatgabhane you can review now, i added the videos, thanks

…-opening-Admins-room

Kalydosos · 2025-01-31T10:57:05Z

@rushatgabhane no changes, just some variables names and synchronisation with main

…-opening-Admins-room

Kalydosos · 2025-02-04T08:25:10Z

@rushatgabhane our PR is ready since 5 days now, like melvin-bot wlll say PRs have feeling too 😃 . Lets move this forward, thx

rushatgabhane · 2025-02-04T08:26:26Z

reviewing today!

rushatgabhane · 2025-02-05T05:17:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

rushatgabhane · 2025-02-05T05:17:28Z

we should remove the extra space in LHN message.

rushatgabhane

i think there is an extra space in the LHN message

…dmins-room

Kalydosos · 2025-02-05T13:23:27Z

we should remove the extra space in LHN message.

@rushatgabhane it's done 👍 plus a little adaptation to a change in main for ReportActionUtils

Kalydosos · 2025-02-06T12:50:02Z

@rushatgabhane as translation files are involved, i think we should move this forward as quicker as possible to avoid frequently resolving conflicts like i did yesterday

rushatgabhane

LGTM!

srikarparsi · 2025-02-06T19:19:29Z

src/languages/en.ts

@@ -5045,6 +5046,7 @@ const translations = {
                    `updated the role of ${email} to ${newRole === 'member' || newRole === 'user' ? 'member' : newRole} (previously ${
                        currentRole === 'member' || currentRole === 'user' ? 'member' : currentRole
                    })`,
+                employeeLeft: ({nameOrEmail}: EmployeeLeftParams) => `${nameOrEmail} left the workspace`,


Can we rename this to leftWorkspace and remove the other occurrence of leftWorkspace

yes, it makes sense 👍

srikarparsi

One change

Kalydosos · 2025-02-06T23:28:16Z

One change

@srikarparsi it's done ! 👍

srikarparsi

looks good, thanks!

OSBotify · 2025-02-06T23:53:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

fix LHN - user name disappear from ws rooms admins

2a1b0ac

Kalydosos requested a review from a team as a code owner January 29, 2025 16:57

melvin-bot bot requested review from rushatgabhane and removed request for a team January 29, 2025 16:57

fix LHN - user name disappear from ws rooms admins

a724278

Kalydosos added 3 commits January 31, 2025 11:40

fix LHN - user name disappears from WS admins room

453d62a

Merge branch 'Expensify:main' into fix-55705-LHN-user-Name-disappears…

af00917

…-opening-Admins-room

fix LHN - user name disappears from WS admins room

e8da57f

Merge branch 'Expensify:main' into fix-55705-LHN-user-Name-disappears…

99bee29

…-opening-Admins-room

rushatgabhane suggested changes Feb 5, 2025

View reviewed changes

Kalydosos added 2 commits February 5, 2025 11:49

Merge branch 'main' into fix-55705-LHN-user-Name-disappears-opening-A…

2f021bc

…dmins-room

fix LHN user name disappears from WS admin rooms

e46461a

rushatgabhane approved these changes Feb 6, 2025

View reviewed changes

melvin-bot bot requested a review from srikarparsi February 6, 2025 13:41

srikarparsi reviewed Feb 6, 2025

View reviewed changes

srikarparsi requested changes Feb 6, 2025

View reviewed changes

fix LHN user name disappears from WS admin rooms

93a8b09

srikarparsi approved these changes Feb 6, 2025

View reviewed changes

srikarparsi merged commit 143f58e into Expensify:main Feb 6, 2025
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix 55705 LHN - user name disappear from ws rooms admins #55974

fix 55705 LHN - user name disappear from ws rooms admins #55974

Kalydosos commented Jan 29, 2025 •

edited

Loading

melvin-bot bot commented Jan 29, 2025

Kalydosos commented Jan 30, 2025

Kalydosos commented Jan 31, 2025

Kalydosos commented Feb 4, 2025

rushatgabhane commented Feb 4, 2025

rushatgabhane commented Feb 5, 2025 •

edited

Loading

rushatgabhane commented Feb 5, 2025 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

Kalydosos commented Feb 5, 2025

Kalydosos commented Feb 6, 2025

rushatgabhane left a comment

srikarparsi Feb 6, 2025

Kalydosos Feb 6, 2025

srikarparsi left a comment

Kalydosos commented Feb 6, 2025

srikarparsi left a comment

OSBotify commented Feb 6, 2025

fix 55705 LHN - user name disappear from ws rooms admins #55974

fix 55705 LHN - user name disappear from ws rooms admins #55974

Conversation

Kalydosos commented Jan 29, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 29, 2025

Kalydosos commented Jan 30, 2025

Kalydosos commented Jan 31, 2025

Kalydosos commented Feb 4, 2025

rushatgabhane commented Feb 4, 2025

rushatgabhane commented Feb 5, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane commented Feb 5, 2025 • edited Loading

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

Kalydosos commented Feb 5, 2025

Kalydosos commented Feb 6, 2025

rushatgabhane left a comment

Choose a reason for hiding this comment

srikarparsi Feb 6, 2025

Choose a reason for hiding this comment

Kalydosos Feb 6, 2025

Choose a reason for hiding this comment

srikarparsi left a comment

Choose a reason for hiding this comment

Kalydosos commented Feb 6, 2025

srikarparsi left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 6, 2025

Kalydosos commented Jan 29, 2025 •

edited

Loading

rushatgabhane commented Feb 5, 2025 •

edited

Loading

rushatgabhane commented Feb 5, 2025 •

edited

Loading

rushatgabhane left a comment •

edited

Loading