-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tasks for new user first workspace #55302
Merged
francoisl
merged 28 commits into
Expensify:main
from
ishpaul777:new-user-workspace-tasks
Jan 30, 2025
Merged
Changes from 27 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
1002d3b
add tasks for new user first workspace
ishpaul777 7014f2d
prettier
ishpaul777 c9b2f4f
replace meetSetupSpecialist task with meetGuideTask and fix guidedSet…
ishpaul777 61609ec
fix upgrade workspace case
ishpaul777 2f8e673
Fix merge conflicts before merging main
ishpaul777 4921332
namespace imports lint failure
ishpaul777 1063cfa
fix Do not default string IDs lint failure
ishpaul777 85c73bb
update onboarding task posting logic for TRACK_WORKSPACE action
ishpaul777 d83382d
workaround for failing lint
ishpaul777 06e71bc
fix: update to correct adminsChatReportID param
ishpaul777 9fa9862
merge main
ishpaul777 e177668
Merge branch 'main' into new-user-workspace-tasks
ishpaul777 b315040
fi onboarding accounting page not showing
ishpaul777 bb02e14
fix: post tasks in admin room
ishpaul777 eb483d1
reverse uninteded change
ishpaul777 8f8c6ec
Merge branch 'Expensify:main' into new-user-workspace-tasks
ishpaul777 c509fd5
fix: eslint
ishpaul777 e757aa3
fix tests
ishpaul777 385fd67
Merge branch 'main' into new-user-workspace-tasks
ishpaul777 70b455f
fix type
ishpaul777 65dd712
revert submodule update
ishpaul777 2eeafd0
Merge branch 'Expensify:main' into new-user-workspace-tasks
ishpaul777 69b6333
fix typing
ishpaul777 fa48e46
fix more type error
ishpaul777 98dbb52
fix report message not sent in payload
ishpaul777 40c93f0
Merge branch 'Expensify:main' into new-user-workspace-tasks
ishpaul777 0e2565a
fix copy
ishpaul777 142545d
merge main
ishpaul777 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ishpaul777 @francoisl do you see a need for adding a comment on why we're passing MANAGE_TEAM ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no strong feelings, but it feel self explanatory if we don't typescript will yell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong feelings either, though I think it might be more beneficial if we add an explanation in the doc of the function definition, in
Policy.ts
. Right now it says@param [engagementChoice] Purpose of using application selected by user in guided setup flow
- we can add a note saying that the default isMANAGE_TEAM
and you can change for specific policy creation flows