add tasks for new user first workspace #55302

ishpaul777 · 2025-01-15T18:26:30Z

Explanation of Change

Fixed Issues

$ #53509
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Sign up with new account and choose "Track and budget expense" in onboarding user intent.
Track a expense
in Selfdm choose to categorize it or share it with my accountant complete the flow.
Verify in you conceriege chat there are new tasks and with a message "Here are some important tasks to help get your team’s expenses under control." and a video

Test 2

Sign up with new account and choose any other option than "Manage my team's expense" in onboarding flow user intent.
Create a new worksapce
Verify in you conceriege chat there are new tasks and with a message "Here are some important tasks to help get your team’s expenses under control." and a video

Offline tests

QA Steps

Same as test steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-17.at.11.43.00.PM.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2025-01-18.at.3.24.19.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-01-18.at.3.41.30.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-17.at.3.53.34.AM.mov

MacOS: Desktop

Screen.Recording.2025-01-30.at.1.26.58.AM.mov

Screen.Recording.2025-01-30.at.1.31.24.AM.mov

…upData being empty

melvin-bot · 2025-01-15T18:34:08Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2025-01-15T18:34:57Z

@shubham1206agra please ignore this one

@mananjadhav will review this

francoisl · 2025-01-15T18:35:48Z

Reassigning C+ for review, this is coming from #55017. Thanks

mananjadhav · 2025-01-15T20:04:15Z

Checked the code, did one pass and most of it looks good. @ishpaul777 Can you complete the author checklist?

I also checked a possibility of refactoring the prepareOnboardingOptimisticData but it's too large to be moved outside of actions. I thought we could send the data with buildPolicyData.

Asking the same question here #55017 (comment).

@francoisl Should we ignore the rule for this particular instance?

src/libs/actions/Report.ts

francoisl · 2025-01-16T05:17:53Z

Looking good - a few things:

We need to update this line to also include the new TRACK_WORKSPACE const – basically now any time we create a workspace, the onboarding tasks should be in the #admins room, not in the Concierge chat, and so the targetChatReportID should be the optimistic admin room's ID.

App/src/libs/actions/Report.ts

Line 3618 in 1063cfa

const shouldPostTasksInAdminsRoom = engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM && !currentUserEmail?.includes('+');
I'm noticing a bug where the video comment is not rendering and stays as [Attachment] forever. That's a backend issue that I'm fixing now, so you can ignore for now
Regarding the no-call-actions-from-actions failure, I'm kind of confused. The action says it's failing on line 2303, which is function createWorkspaceFromIOUPayment(), which hasn't changed here... Or is it because of prepareOnboardingOnyxData()? Regardless, as far as I can tell, that action should only fail if you call an action within an action that calls the API (https://github.com/Expensify/eslint-config-expensify/blob/acac69e60be8c/eslint-plugin-expensify/no-call-actions-from-actions.js), which neither prepareOnboardingOnyxData() nor buildPolicyData() does 🙃 I don't feel great about ignoring the rule without fully understanding why it's even erroring now.

ishpaul777 · 2025-01-16T19:58:19Z

We need to update this line to also include the new TRACK_WORKSPACE const – basically now any time we create a workspace, the onboarding tasks should be in the #admins room, not in the Concierge chat, and so the targetChatReportID should be the optimistic admin room's ID.

will address this soon..

Can you complete the author checklist?

yes i'll do it right right after ^

ishpaul777 · 2025-01-16T23:07:16Z

I'm noticing a bug where the video comment is not rendering and stays as [Attachment] forever. That's a backend issue that I'm fixing now, so you can ignore for now

there is also one more bug that this message "Here are some important tasks to help get your team’s expenses under control." goes away after createworkspace api command is success, can you please check that one as well please it looks like BE issue

ishpaul777 · 2025-01-16T23:10:15Z

The action says it's failing on line 2303, which is function createWorkspaceFromIOUPayment(), which hasn't changed here... Or is it because of prepareOnboardingOnyxData()?

my best guess is that this because of prepareOnboardingOnyxData that is why its fixed with this d83382d workaround

francoisl · 2025-01-17T00:01:11Z

there is also one more bug that this message "Here are some important tasks to help get your team’s expenses under control." goes away after createworkspace api command is success

I'm not even seeing that message being sent in the CreateWorkspace payload, nor the video actually 🤔

francoisl · 2025-01-17T00:10:08Z

For some reason the video and message come back if I revert this commit.

mananjadhav · 2025-01-29T11:47:25Z

src/libs/actions/App.ts

@@ -424,7 +424,7 @@ function createWorkspaceWithPolicyDraftAndNavigateToIt(
 * @param [file] Optional, avatar file for workspace
 */
 function savePolicyDraftByNewWorkspace(policyID?: string, policyName?: string, policyOwnerEmail = '', makeMeAdmin = false, currency = '', file?: File) {
-    createWorkspace(policyOwnerEmail, makeMeAdmin, policyName, policyID, '', currency, file);
+    createWorkspace(policyOwnerEmail, makeMeAdmin, policyName, policyID, CONST.ONBOARDING_CHOICES.MANAGE_TEAM, currency, file);


@ishpaul777 @francoisl do you see a need for adding a comment on why we're passing MANAGE_TEAM ?

no strong feelings, but it feel self explanatory if we don't typescript will yell

No strong feelings either, though I think it might be more beneficial if we add an explanation in the doc of the function definition, in Policy.ts. Right now it says @param [engagementChoice] Purpose of using application selected by user in guided setup flow - we can add a note saying that the default is MANAGE_TEAM and you can change for specific policy creation flows

mananjadhav

Reviewed the code changes, will do a final review once more and then start testing this.

mananjadhav · 2025-01-29T16:07:19Z

@ishpaul777 I had raised a comment earlier regarding the markdown text. Can you please take a look? The whole text starting from Invite your account... second bullet 2. Go to *Workspaces is bold.

Also I completed the Invite Accountant flow, I don't see the tasks on the Concierge chat.

ishpaul777 · 2025-01-29T19:05:42Z

Also I completed the Invite Accountant flow, I don't see the tasks on the Concierge chat.

@mananjadhav does your test account includes a + in email. the way logic currently is if you have + in email it will be posted in conceirge chat otherwise it will be posted in admins room of new workspace.

mananjadhav · 2025-01-30T05:50:33Z

I did check the #admin room. Let me try with an email with +.

mananjadhav · 2025-01-30T17:55:22Z

Sorry I think I messed up the branch or something. The test works fine. @ishpaul777 I am working on the checklist, can you please resolve the conflicts?

mananjadhav · 2025-01-30T17:59:34Z

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web-invite-accountant-concierge.mp4

web-invite-accountant.mov

MacOS: Desktop

mananjadhav · 2025-01-30T18:20:09Z

I am having issues with my iOS Mobile Web Safari. The signup API is giving 429 errors abruptly. Finishing the checklist without that, will uploaded it may be later.

mananjadhav · 2025-01-30T18:20:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

mananjadhav

Waiting on uploading the mobile web safari screenshot and resolving merge conflicts. Meanwhile @francoisl All yours.

ishpaul777 · 2025-01-30T18:25:35Z

I am on it! @mananjadhav

ishpaul777 · 2025-01-30T19:20:28Z

it seems like we removed logic for adding the onboarding videos in this issue

#55642 (comment)

github-actions · 2025-01-30T19:20:44Z

🚧 @francoisl has triggered a test build. You can view the workflow run here.

francoisl · 2025-01-30T19:23:01Z

it seems like we removed logic for adding the onboarding videos in this issue

#55642 (comment)

👍 I had no idea. Things change too fast 😂

github-actions · 2025-01-30T19:46:09Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55302/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/55302/NewExpensify.dmg	https://55302.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

francoisl · 2025-01-30T19:46:48Z

Ok, tests well for me locally! Going to try to give it a quick run on Android once the ad-hoc build finishes, but so far I think it's ready to merge.

francoisl

Working well for me too, let's ship this 🚀

OSBotify · 2025-01-30T20:26:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

roryabraham · 2025-01-31T01:34:11Z

Hi 👋🏼

Due to an unfortunate mistake, this code has been deleted from main, and this PR needs to be re-created from scratch. There are some additional details in slack here. Feel free to tag me in slack if you have questions. Apologies for the inconvenience 🙇🏼

ishpaul777 · 2025-01-31T10:08:42Z

here's the new PR #56141 @francoisl @mananjadhav

shubham1206agra · 2025-02-02T17:28:16Z

src/libs/actions/Report.ts

@@ -3681,6 +3687,20 @@ function prepareOnboardingOptimisticData(
            if (['addAccountingIntegration', 'setupCategoriesAndTags'].includes(task.type) && !userReportedIntegration) {
                return false;
            }
+            type SkipViewTourOnboardingChoices = 'newDotSubmit' | 'newDotSplitChat' | 'newDotPersonalSpend' | 'newDotEmployer';


@ishpaul777 @mananjadhav I don't think this is a good place to declare type.

ishpaul777 and others added 4 commits January 15, 2025 23:51

add tasks for new user first workspace

1002d3b

prettier

7014f2d

replace meetSetupSpecialist task with meetGuideTask and fix guidedSet…

c9b2f4f

…upData being empty

fix upgrade workspace case

61609ec

This was referenced Jan 15, 2025

[Due for payment 2025-02-13] [Add onboarding for new workspaces being created] Create new setup tasks when users create a workspace #53509

Open

add tasks for new user first workspace #55017

Closed

Fix merge conflicts before merging main

2f8e673

ishpaul777 marked this pull request as ready for review January 15, 2025 18:34

ishpaul777 requested a review from a team as a code owner January 15, 2025 18:34

melvin-bot bot requested review from shubham1206agra and removed request for a team January 15, 2025 18:34

francoisl requested a review from mananjadhav January 15, 2025 18:35

francoisl requested review from francoisl and removed request for shubham1206agra January 15, 2025 18:35

ishpaul777 added 2 commits January 16, 2025 00:11

namespace imports lint failure

4921332

fix Do not default string IDs lint failure

1063cfa

francoisl reviewed Jan 16, 2025

View reviewed changes

src/libs/actions/Report.ts Outdated Show resolved Hide resolved

ishpaul777 added 3 commits January 17, 2025 03:13

update onboarding task posting logic for TRACK_WORKSPACE action

85c73bb

workaround for failing lint

d83382d

fix: update to correct adminsChatReportID param

06e71bc

mananjadhav reviewed Jan 29, 2025

View reviewed changes

fix copy

0e2565a

mananjadhav approved these changes Jan 30, 2025

View reviewed changes

melvin-bot bot requested a review from francoisl January 30, 2025 18:23

merge main

142545d

francoisl approved these changes Jan 30, 2025

View reviewed changes

francoisl merged commit e39dfbc into Expensify:main Jan 30, 2025
16 checks passed

This was referenced Jan 30, 2025

Investigate workflow job failing on main: test / test (job 3) #56115

Closed

Investigate workflow job failing on main: confirmPassingBuild #56116

Closed

francoisl mentioned this pull request Jan 31, 2025

New user workspace tasks #56141

Merged

50 tasks

shubham1206agra reviewed Feb 2, 2025

View reviewed changes

MarioExpensify mentioned this pull request Feb 4, 2025

[Due for payment 2025-02-18] [Due for payment 2025-02-13] Workspace - Setup specialist appears in member list and throws error when invited #56351

Closed

8 tasks

NJ-2020 mentioned this pull request Feb 6, 2025

Workspace - Admins room is not displayed for a second created workspace #56344

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add tasks for new user first workspace #55302

add tasks for new user first workspace #55302

ishpaul777 commented Jan 15, 2025 •

edited

Loading

melvin-bot bot commented Jan 15, 2025

ishpaul777 commented Jan 15, 2025

francoisl commented Jan 15, 2025

mananjadhav commented Jan 15, 2025 •

edited

Loading

francoisl commented Jan 16, 2025 •

edited

Loading

ishpaul777 commented Jan 16, 2025 •

edited

Loading

ishpaul777 commented Jan 16, 2025

ishpaul777 commented Jan 16, 2025

francoisl commented Jan 17, 2025

francoisl commented Jan 17, 2025

mananjadhav Jan 29, 2025

ishpaul777 Jan 29, 2025

francoisl Jan 30, 2025

mananjadhav left a comment

mananjadhav commented Jan 29, 2025 •

edited

Loading

ishpaul777 commented Jan 29, 2025 •

edited

Loading

mananjadhav commented Jan 30, 2025

mananjadhav commented Jan 30, 2025

mananjadhav commented Jan 30, 2025 •

edited

Loading

mananjadhav commented Jan 30, 2025

mananjadhav commented Jan 30, 2025 •

edited

Loading

mananjadhav left a comment

ishpaul777 commented Jan 30, 2025

ishpaul777 commented Jan 30, 2025

github-actions bot commented Jan 30, 2025

francoisl commented Jan 30, 2025

github-actions bot commented Jan 30, 2025

francoisl commented Jan 30, 2025

francoisl left a comment

OSBotify commented Jan 30, 2025

roryabraham commented Jan 31, 2025

ishpaul777 commented Jan 31, 2025

shubham1206agra Feb 2, 2025

add tasks for new user first workspace #55302

add tasks for new user first workspace #55302

Conversation

ishpaul777 commented Jan 15, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 15, 2025

ishpaul777 commented Jan 15, 2025

francoisl commented Jan 15, 2025

mananjadhav commented Jan 15, 2025 • edited Loading

francoisl commented Jan 16, 2025 • edited Loading

ishpaul777 commented Jan 16, 2025 • edited Loading

ishpaul777 commented Jan 16, 2025

ishpaul777 commented Jan 16, 2025

francoisl commented Jan 17, 2025

francoisl commented Jan 17, 2025

mananjadhav Jan 29, 2025

Choose a reason for hiding this comment

ishpaul777 Jan 29, 2025

Choose a reason for hiding this comment

francoisl Jan 30, 2025

Choose a reason for hiding this comment

mananjadhav left a comment

Choose a reason for hiding this comment

mananjadhav commented Jan 29, 2025 • edited Loading

ishpaul777 commented Jan 29, 2025 • edited Loading

mananjadhav commented Jan 30, 2025

mananjadhav commented Jan 30, 2025

mananjadhav commented Jan 30, 2025 • edited Loading

Screenshots/Videos

mananjadhav commented Jan 30, 2025

mananjadhav commented Jan 30, 2025 • edited Loading

Reviewer Checklist

mananjadhav left a comment

Choose a reason for hiding this comment

ishpaul777 commented Jan 30, 2025

ishpaul777 commented Jan 30, 2025

github-actions bot commented Jan 30, 2025

francoisl commented Jan 30, 2025

github-actions bot commented Jan 30, 2025

francoisl commented Jan 30, 2025

francoisl left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 30, 2025

roryabraham commented Jan 31, 2025

ishpaul777 commented Jan 31, 2025

shubham1206agra Feb 2, 2025

Choose a reason for hiding this comment

ishpaul777 commented Jan 15, 2025 •

edited

Loading

mananjadhav commented Jan 15, 2025 •

edited

Loading

francoisl commented Jan 16, 2025 •

edited

Loading

ishpaul777 commented Jan 16, 2025 •

edited

Loading

mananjadhav commented Jan 29, 2025 •

edited

Loading

ishpaul777 commented Jan 29, 2025 •

edited

Loading

mananjadhav commented Jan 30, 2025 •

edited

Loading

mananjadhav commented Jan 30, 2025 •

edited

Loading