-
Notifications
You must be signed in to change notification settings - Fork 362
Custom scalar input #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Custom scalar input #636
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88 changes: 88 additions & 0 deletions
88
...or/src/test/kotlin/com/expediagroup/graphql/test/integration/CustomScalarExecutionTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,88 @@ | ||
/* | ||
* Copyright 2020 Expedia, Inc | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.expediagroup.graphql.test.integration | ||
|
||
import com.expediagroup.graphql.TopLevelObject | ||
import com.expediagroup.graphql.getTestSchemaConfigWithHooks | ||
import com.expediagroup.graphql.hooks.SchemaGeneratorHooks | ||
import com.expediagroup.graphql.test.utils.graphqlUUIDType | ||
import com.expediagroup.graphql.toSchema | ||
import graphql.GraphQL | ||
import graphql.schema.GraphQLType | ||
import org.junit.jupiter.api.Test | ||
import java.util.UUID | ||
import kotlin.reflect.KClass | ||
import kotlin.reflect.KType | ||
import kotlin.test.assertFails | ||
import kotlin.test.assertNotNull | ||
|
||
class CustomScalarExecutionTest { | ||
|
||
private val schema = toSchema( | ||
queries = listOf(TopLevelObject(QueryObject())), | ||
config = getTestSchemaConfigWithHooks(CustomScalarHooks()) | ||
) | ||
private val graphQL: GraphQL = GraphQL.newGraphQL(schema).build() | ||
|
||
@Test | ||
fun `a custom scalar can be used as output`() { | ||
val result = graphQL.execute("{ uuidOutput }") | ||
val data: Map<String, String>? = result.getData() | ||
|
||
assertNotNull(data?.get("uuidOutput")) | ||
} | ||
|
||
@Test | ||
fun `a custom scalar can be used as input`() { | ||
val result = graphQL.execute("{ uuidInput(uuid: \"22dba784-f7c1-471f-8e8c-84e3a59bb5b5\") }") | ||
val data: Map<String, String>? = result.getData() | ||
|
||
assertNotNull(data?.get("uuidInput")) | ||
} | ||
|
||
@Test | ||
fun `an invalid custom scalar as input will throw an error`() { | ||
assertFails { | ||
graphQL.execute("{ uuidInput(uuid: \"foo\") }") | ||
} | ||
} | ||
|
||
@Test | ||
fun `a custom scalar can be used as input in a list`() { | ||
val result = graphQL.execute("{ uuidListInput(uuids: [\"435f5808-936b-40ab-89b6-ec4e8cd1ba36\"]) }") | ||
val data: Map<String, String>? = result.getData() | ||
|
||
assertNotNull(data?.get("uuidListInput")) | ||
} | ||
|
||
class QueryObject { | ||
fun uuidOutput(): UUID = UUID.randomUUID() | ||
|
||
fun uuidInput(uuid: UUID) = "You sent $uuid" | ||
|
||
fun uuidListInput(uuids: List<UUID>) = "You sent ${uuids.size} items" | ||
smyrick marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
class CustomScalarHooks : SchemaGeneratorHooks { | ||
override fun willGenerateGraphQLType(type: KType): GraphQLType? { | ||
return when (type.classifier as? KClass<*>) { | ||
UUID::class -> graphqlUUIDType | ||
else -> null | ||
} | ||
} | ||
} | ||
} |
44 changes: 44 additions & 0 deletions
44
...n-schema-generator/src/test/kotlin/com/expediagroup/graphql/test/utils/graphqlUuidType.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
/* | ||
* Copyright 2020 Expedia, Inc | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.expediagroup.graphql.test.utils | ||
|
||
import graphql.language.StringValue | ||
import graphql.schema.Coercing | ||
import graphql.schema.GraphQLScalarType | ||
import java.util.UUID | ||
|
||
/** | ||
* Custom scalar to parse a string as a [UUID] for both input and output. | ||
*/ | ||
internal val graphqlUUIDType = GraphQLScalarType.newScalar() | ||
.name("UUID") | ||
.description("A type representing a formatted java.util.UUID") | ||
.coercing(UUIDCoercing) | ||
.build() | ||
|
||
private object UUIDCoercing : Coercing<UUID, String> { | ||
override fun parseValue(input: Any?): UUID = UUID.fromString(serialize(input)) | ||
|
||
override fun parseLiteral(input: Any?): UUID? { | ||
val uuidString: String? = (input as? StringValue)?.value | ||
return if (uuidString != null) { | ||
UUID.fromString(uuidString) | ||
} else null | ||
} | ||
|
||
override fun serialize(dataFetcherResult: Any?): String = dataFetcherResult.toString() | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.