Custom scalar input #636
Merged
Custom scalar input #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsparrow
reviewed
Mar 9, 2020
...rator/src/test/kotlin/com/expediagroup/graphql/test/integration/CustomScalarExecutionTest.kt
Outdated
Show resolved
Hide resolved
alexsparrow
reviewed
Mar 9, 2020
...rator/src/test/kotlin/com/expediagroup/graphql/test/integration/CustomScalarExecutionTest.kt
Outdated
Show resolved
Hide resolved
Converting a list input type for custom scalars was losing the type information. We need to use a specific Jackson conversion method to properly convert the List interface
smyrick
added
changes: patch
tapaderster
approved these changes
Mar 11, 2020
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
* Add more tests for custom scalar input * Undo api changes * Fix input for lists of custom scalars Converting a list input type for custom scalars was losing the type information. We need to use a specific Jackson conversion method to properly convert the List interface * Remove reference to external classes in javadoc Co-authored-by: Shane Myrick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Converting a list input type for custom scalars was losing the type information. We need to use a specific Jackson conversion method to properly convert the List interface
🔗 Related Issues
#635