Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hub-common): remove all collection, update default collection definitions, start persisting IHubCatalog to sites #1833

Merged
merged 14 commits into from
Mar 28, 2025
Merged

feat(hub-common): remove all collection, update default collection definitions, start persisting IHubCatalog to sites #1833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
47bb8c7
feat(hub-common): removes the "all" collection from being returned as…
sonofflynn89 Mar 18, 2025
17140b9
feat(hub-common): site collections use "well known predicates" instea…
sonofflynn89 Mar 19, 2025
c3c9568
feat(hub-common): add site migration to persist new catalog at data.c…
sonofflynn89 Mar 21, 2025
83380b0
feat(hub-common): remove unused completeOAuth2 wrapper function
tomwayson Mar 24, 2025
1f67b8e
feat(hub-common): logLevel defaults to error and is read-only
tomwayson Mar 26, 2025
8d3137c
test(hub-sites): spy on Logger instead of console
tomwayson Mar 26, 2025
5a090cc
feat(hub-sites): migrate site draft catalogs to v2
tomwayson Mar 26, 2025
ca29507
refactor(hub-common): remove deprecated getAddContentConfig and relat…
tomwayson Mar 27, 2025
ee36d7e
refactor(hub-common): remove unused hub:project:workspace:catalogs pe…
tomwayson Mar 27, 2025
f6978be
refactor(hub-common): remove unused expandQuery (internal) function
tomwayson Mar 27, 2025
671f18d
refactor(hub-sites): remove deprecated _shareItemsToSiteGroups function
tomwayson Mar 27, 2025
f1259f1
refactor: remove deprecated hub-discussions package
tomwayson Mar 27, 2025
ea8f7e2
feat(hub-common): add searchCategoriesToCollections() helper function
sonofflynn89 Mar 27, 2025
4e2d8ef
fix(hub-common): fix issue where users could not remove all groups fr…
sonofflynn89 Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 packages/discussions/CHANGELOG.md → archive/discussions/CHANGELOG.md
View file
Open in desktop
File renamed without changes.
11 changes: 11 additions & 0 deletions archive/discussions/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# @esri/hub-discussions

## IMPORTANT NOTICE:

> **This package has been deprecated.**

`@esri/hub-discussions` has been merged into `@esri/hub-common` beginning with `@esri/hub-common` version `15.38.0`. Please update your project dependencies and import statements to use `@esri/hub-common`.

See [that package](../../packages/common/README.md) for more information.

You can also view the archived [CHANGELOG](./CHANGELOG.md) for a history of changes prior to having been merged into `@esri/hub-common`.
50 changes: 19 additions & 31 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions packages/common/src/ArcGISContextManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,6 @@ export class ArcGISContextManager {
// Having a unique id makes debugging easier
this.id = new Date().getTime();

// TODO: remove all log level logic at next breaking change
if (opts.logLevel) {
Logger.setLogLevel(opts.logLevel);
}

Logger.debug(`ArcGISContextManager:ctor: Creating ${this.id}`);

if (opts.properties) {
Expand Down
41 changes: 0 additions & 41 deletions packages/common/src/auth.ts
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions packages/common/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ export * from "./access";
export * from "./api";
export * from "./ArcGISContext";
export * from "./ArcGISContextManager";
export * from "./auth";
export * from "./categories";
export * from "./content";
export * from "./core";
Expand Down Expand Up @@ -53,7 +52,6 @@ export * from "./core/EntityEditor";
// Unclear _why_ this needs to be here vs. in search/index.ts
// but if it's exported there, it's not actually exporeted
export * from "./search/explainQueryResult";
export * from "./search/getAddContentConfig";
export * from "./search/getCatalogGroups";
export * from "./search/getPredicateValues";
export * from "./search/getUserGroupsByMembership";
Expand Down
11 changes: 0 additions & 11 deletions packages/common/src/projects/_internal/ProjectBusinessRules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ export const ProjectPermissions = [
"hub:project:workspace:content",
"hub:project:workspace:events",
"hub:project:workspace:metrics",
"hub:project:workspace:catalogs", // deprecated - should be removed
"hub:project:workspace:catalog",
"hub:project:manage",
] as const;
Expand Down Expand Up @@ -167,16 +166,6 @@ export const ProjectPermissionPolicies: IPermissionPolicy[] = [
permission: "hub:project:workspace:metrics",
dependencies: ["hub:project:workspace", "hub:project:edit"],
},
// DEPRECATED - use hub:project:workspace:catalog instead
// TODO: remove in next breaking change
{
permission: "hub:project:workspace:catalogs",
dependencies: [
"hub:project:workspace",
"hub:feature:catalogs",
"hub:project:edit",
],
},
{
permission: "hub:project:workspace:catalog",
dependencies: ["hub:project:workspace", "hub:project:edit"],
Expand Down
Loading