feat(hub-common): removes the "all" collection from being returned as part of a site's catalog #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… part of a site's catalog; FE c affects: @esri/hub-common BREAKING CHANGE: getCatalogFromSiteModel() no longer includes the "all" collection
…d of "well known collections" affects: @esri/hub-common
abp6318
approved these changes
Mar 20, 2025
…atalogV2 affects: @esri/hub-common, @esri/hub-sites
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1833 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 1054 1072 +18
Lines 19199 19482 +283
Branches 3476 3532 +56
==========================================
+ Hits 19199 19482 +283 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
affects: @esri/hub-common
BREAKING CHANGE:
getCatalogFromSiteModel() no longer includes the "all" collection
We need to stop returning the "all" collection when calculating a site catalog as we do not ever intend to persist it in the data.json. FE and BE consumers of site catalogs that need to display an "all" collection will need to add one as a display-only collection.
Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide
used semantic commit messages
PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)