Feat/t218 bls sig arkworks

primitives/src/constants.rs

@@ -9,7 +9,7 @@
 /// ciphersuite identifier for schnorr signature
 pub const CS_ID_SCHNORR: &str = "SCHNORR_WITH_RESCUE_HASH_v01";
 
-/// ciphersuite identifier for BLS signature, see:
+/// ciphersuite identifier for BLS signature over BLS12_381, see:
 /// <https://www.ietf.org/archive/id/draft-irtf-cfrg-bls-signature-05.html#name-ciphersuite-format>
 pub const CS_ID_BLS_MIN_SIG: &str = "BLS_SIG_BLS12381G1_XMD:SHA-256_SSWU_RO_NUL_";
 
@@ -23,3 +23,8 @@ pub const BLS_SIG_COMPRESSED_SIGNATURE_SIZE: usize = 48;
 pub const BLS_SIG_PK_SIZE: usize = 192;
 /// Size in bytes of a compressed verification key in our BLS signature scheme.
 pub const BLS_SIG_COMPRESSED_PK_SIZE: usize = 96;
+
+/// ciphersuite identifier for BLS signature over BN254
+/// Note this is **adapted** from <https://www.ietf.org/archive/id/draft-irtf-cfrg-bls-signature-05.html#name-ciphersuite-format>.
+/// In particular the "hash-and-pray" method is not part of <https://datatracker.ietf.org/doc/html/draft-irtf-cfrg-hash-to-curve-16>, so the tag "NCTH" (non constant time hash) is not standard.
+pub const CS_ID_BLS_BN254: &str = "BLS_SIG_BN254G1_XMD:KECCAK_NCTH_NUL_";

primitives/src/signatures/bls.rs → primitives/src/signatures/bls_over_bls12381.rs

@@ -16,7 +16,7 @@
 //!
 //! ```
 //! use rand_core::{RngCore, OsRng};
-//! use jf_primitives::signatures::{SignatureScheme, bls::BLSSignatureScheme};
+//! use jf_primitives::signatures::{SignatureScheme, bls_over_bls12381::BLSSignatureScheme};
 //!
 //! let pp = BLSSignatureScheme::param_gen::<OsRng>(None)?;
 //!
@@ -40,7 +40,7 @@
 //! ```
 //! use rand_core::{RngCore, OsRng};
 //! use sha2::{Sha256, Digest};
-//! use jf_primitives::signatures::{SignatureScheme, bls::BLSSignatureScheme};
+//! use jf_primitives::signatures::{SignatureScheme, bls_over_bls12381::BLSSignatureScheme};
 //!
 //! let pp = BLSSignatureScheme::param_gen::<OsRng>(None)?;
 //!
@@ -73,11 +73,12 @@ use super::SignatureScheme;
 use crate::{
     constants::{
         BLS_SIG_COMPRESSED_PK_SIZE, BLS_SIG_COMPRESSED_SIGNATURE_SIZE, BLS_SIG_PK_SIZE,
-        BLS_SIG_SIGNATURE_SIZE, BLS_SIG_SK_SIZE, CS_ID_BLS_MIN_SIG,
+        BLS_SIG_SIGNATURE_SIZE, BLS_SIG_SK_SIZE,
     },
     errors::PrimitivesError,
 };
 
+use crate::constants::CS_ID_BLS_MIN_SIG;
 use ark_serialize::*;
 use ark_std::{
     format,
@@ -325,15 +326,15 @@ pub struct BLSSignatureScheme;
 impl SignatureScheme for BLSSignatureScheme {
     const CS_ID: &'static str = CS_ID_BLS_MIN_SIG;
 
-    /// Public parameter
-    type PublicParameter = ();
-
     /// Signing key
     type SigningKey = BLSSignKey;
 
     /// Verification key
     type VerificationKey = BLSVerKey;
 
+    /// Public parameter
+    type PublicParameter = ();
+
     /// Signature
     type Signature = BLSSignature;