Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/t218 bls sig arkworks #223

Merged
merged 25 commits into from
Apr 5, 2023
Merged

Feat/t218 bls sig arkworks #223

merged 25 commits into from
Apr 5, 2023

Conversation

philippecamacho
Copy link
Contributor

Closes: #218

@philippecamacho
Skeleton of code compiling
5dc6d75
@philippecamacho
Fix type errors
dd40098
@philippecamacho
Merge branch 'main' into feat/t218-bls-sig-arkworks
c7b36f7
@philippecamacho
Fix trait errors
c566707
@philippecamacho
Key pair generation
17c4ab5
@philippecamacho
Fix clippy error.
52b45ef
@philippecamacho
Sketch for hash to curve.
ff4ecbc
@philippecamacho
Remove type parameter P:Pairing.
2ba50b4
@philippecamacho
Revert "Remove type parameter P:Pairing."
d25d39d 
This reverts commit 2ba50b4.
@philippecamacho
Revert "Revert "Remove type parameter P:Pairing.""
6f86ed3 
This reverts commit d25d39d.
@philippecamacho
First version of hash and pray function for Bn254 curve.
5192c55
@philippecamacho
Signature trait tests passing.
b9f6038
@philippecamacho
Take into account the algorithm id
b53f097
@philippecamacho
Remove commented code.
c16c1d8
@philippecamacho
Fix ID of signature algorithm.
9ca2f68
@philippecamacho
Serde tests
5160bea
@philippecamacho
Parametrize hash_to_curve with the hash function for mapping bytes …
203af5e 
…to a field element.
@philippecamacho
Add some comments / todos.
ba4825b
@philippecamacho
Document hash_to_curve function.
af922fe
@philippecamacho
Misc improvements, renaming.
4491b3c
@philippecamacho philippecamacho marked this pull request as ready for review April 4, 2023 21:54
chancharles92
chancharles92 reviewed Apr 5, 2023
View reviewed changes
Copy link
Contributor

@chancharles92 chancharles92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @philippecamacho ! Left a few comments.

primitives/src/constants.rs Outdated Show resolved Hide resolved
primitives/src/signatures/bls_over_bn254.rs Outdated Show resolved Hide resolved
primitives/src/signatures/bls_over_bn254.rs Show resolved Hide resolved
primitives/src/signatures/bls_over_bn254.rs Outdated Show resolved Hide resolved
primitives/src/signatures/bls_over_bn254.rs Show resolved Hide resolved
@philippecamacho philippecamacho requested a review from nyospe April 5, 2023 16:25
@philippecamacho philippecamacho merged commit 29829f4 into main Apr 5, 2023
@philippecamacho philippecamacho deleted the feat/t218-bls-sig-arkworks branch April 5, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chancharles92 chancharles92 chancharles92 approved these changes

@nyospe nyospe Awaiting requested review from nyospe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support BN curves in the BLS aggregate signature
2 participants
@philippecamacho @chancharles92