Skip to content

EvseManager: remove config options for current limits #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhei wants to merge 1 commit into
base: main
Choose a base branch
from
Open

EvseManager: remove config options for current limits #1736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions config/config-CB-EVAL-DC.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ active_modules:
ev_receipt_required: false
evse_id: DE*PNX*E12345*1
has_ventilation: true
max_current_import_A: 16
max_current_export_A: 16
payment_enable_contract: false
payment_enable_eim: true
session_logging: true
Expand Down
2 changes: 0 additions & 2 deletions config/config-CB-SAT-AC-powermeter-iso20.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ active_modules:
ev_receipt_required: false
evse_id: DE*PNX*E12345*1
has_ventilation: true
max_current_import_A: 16
max_current_export_A: 16
payment_enable_contract: false
payment_enable_eim: true
session_logging: true
Expand Down
2 changes: 0 additions & 2 deletions config/config-CB-SAT-AC-powermeter.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ active_modules:
ev_receipt_required: false
evse_id: DE*PNX*E12345*1
has_ventilation: true
max_current_import_A: 16
max_current_export_A: 16
payment_enable_contract: false
payment_enable_eim: true
session_logging: true
Expand Down
2 changes: 0 additions & 2 deletions config/config-CB-SAT-AC.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ active_modules:
ev_receipt_required: false
evse_id: DE*PNX*E12345*1
has_ventilation: true
max_current_import_A: 16
max_current_export_A: 16
payment_enable_contract: false
payment_enable_eim: true
session_logging: true
Expand Down
2 changes: 0 additions & 2 deletions config/config-sil-ac-d20.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ active_modules:
ev_receipt_required: false
evse_id: DE*PNX*E12345*1
has_ventilation: true
max_current_import_A: 32
max_current_export_A: 32
payment_enable_contract: false
payment_enable_eim: true
session_logging: true
Expand Down
2 changes: 0 additions & 2 deletions config/config-sil.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,6 @@ active_modules:
ev_receipt_required: false
evse_id: DE*PNX*E12345*1
has_ventilation: true
max_current_import_A: 32
max_current_export_A: 32
payment_enable_contract: true
payment_enable_eim: true
session_logging: true
Expand Down
7 changes: 0 additions & 7 deletions modules/EVSE/EvseManager/EvseManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,13 +147,6 @@ void EvseManager::init() {
{
std::scoped_lock lock(hw_caps_mutex);
hw_capabilities = c;
// Maybe override with user setting for this EVSE
if (config.max_current_import_A < hw_capabilities.max_current_A_import) {
hw_capabilities.max_current_A_import = config.max_current_import_A;
}
if (config.max_current_export_A < hw_capabilities.max_current_A_export) {
hw_capabilities.max_current_A_export = config.max_current_export_A;
}
}

if (ac_nr_phases_active == 0) {
Expand Down
2 changes: 0 additions & 2 deletions modules/EVSE/EvseManager/EvseManager.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ struct Conf {
std::string session_logging_path;
bool session_logging_xml;
bool has_ventilation;
double max_current_import_A;
double max_current_export_A;
std::string charge_mode;
bool supported_iso_ac_bpt;
bool ac_hlc_enabled;
Expand Down
8 changes: 0 additions & 8 deletions modules/EVSE/EvseManager/manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,6 @@ config:
description: Allow ventilated charging or not
type: boolean
default: true
max_current_import_A:
description: User configurable current limit for this EVSE in Ampere
type: number
default: 32
max_current_export_A:
description: User configurable current limit for this EVSE in Ampere
type: number
default: 32
charge_mode:
description: Select charging mode
type: string
Expand Down
Loading