EvseManager: remove config options for current limits #1736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhei
requested review from
Pietfried,
SebaLukas,
corneliusclaussen,
hikinggrass and
mlitre
as code owners
Contributor
|
We could also remove the limits options from evse Manager altogether. It is more of a left over from times before the bsp reported capabilities. It is maybe cleaner to only set it in the bsp. What do you think? |
Contributor
Author
|
That would be perfectly fine with me. I didn't want to destroy any existing use-cases, hence this conservative approach. But I'm happy to amend this PR to remove both options. |
mhei
force-pushed
the
feature/pr-evsemanager-dont-fiddle-bsp-caps
branch
from
af1c8fc to
bf221ec
Compare
mhei
changed the title
Pietfried
previously approved these changes
Jan 16, 2026
cburandt
reviewed
Jan 16, 2026
Contributor
cburandt
left a comment
cburandt
left a comment
There was a problem hiding this comment.
Please have a look at the existing config yamls and remove the config options you are removing from there as well (I think at least config-sil.yaml uses them).
Once upon a time, the BSP modules had no capabilities, yet it was still necessary to define limits for the EVSE. At this point, these two config parameters were introduced. However, meanwhile the BSP modules report was is possible by hardware and very often, this is also user configurable. So the need for these two parameters is gone and it would also be hard to maintain in real deployments. Especially, when hardware caps are reported kind of dynamically by the BSP (for example when using DIP switches and/or rotary encoder switches). Signed-off-by: Michael Heimpold <[email protected]>
mhei
force-pushed
the
feature/pr-evsemanager-dont-fiddle-bsp-caps
branch
from
bf221ec to
b8ef825
Compare
cburandt
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
It seems that all open-source BSP modules allow to manually set hardware capabilities via config options. So having additional limits in EvseManager can be useful, but is also hard to maintain in real deployments. Especially, when hardware caps are reported kind of dynamically by the BSP (for example when using DIP switches and rotary encoder switches).
As discussed, this PR was updated to remove these parameters.
Issue ticket number and link
none
Checklist before requesting a review