Skip to content

feat(voltage_plausibility_monitor): Voltage plausibility check during DC charging to detect configuration of hardware inconsistencies #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
florinmihut wants to merge 2 commits into
base: main
Choose a base branch
from

Fix bazel and formatting

f550ae1
Select commit
Loading
Failed to load commit list.
Open

feat(voltage_plausibility_monitor): Voltage plausibility check during DC charging to detect configuration of hardware inconsistencies #1711

Fix bazel and formatting
f550ae1
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Jan 13, 2026 in 0s

19 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 19
           

Complexity increasing per file
==============================
- modules/EVSE/EvseManager/ErrorHandling.cpp  4
- modules/EVSE/EvseManager/EvseManager.cpp  11
- modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.cpp  47
         

Clones added
============
- modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.cpp  2

See the complete overview on Codacy

Annotations

Check warning on line 6 in modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.cpp#L6 

Include file: <algorithm> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 7 in modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.cpp#L7 

Include file: <chrono> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 8 in modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.cpp#L8 

Include file: <cmath> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 9 in modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.cpp#L9 

Include file: <condition_variable> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 10 in modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.cpp#L10 

Include file: <fmt/core.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 11 in modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.cpp#L11 

Include file: <thread> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 6 in modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp#L6 

Include file: <chrono> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 7 in modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp#L7 

Include file: <condition_variable> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 8 in modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp#L8 

Include file: <functional> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 9 in modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp#L9 

Include file: <mutex> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 10 in modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp#L10 

Include file: <string> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 11 in modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp#L11 

Include file: <thread> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 91 in modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp#L91 

struct member 'VoltageSample::voltage_V' is never used.

Check warning on line 103 in modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp#L103 

class member 'VoltagePlausibilityMonitor::std_deviation_threshold_V_' is never used.

Check warning on line 106 in modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp#L106 

class member 'VoltagePlausibilityMonitor::running_' is never used.

Check warning on line 107 in modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp#L107 

class member 'VoltagePlausibilityMonitor::fault_latched_' is never used.

Check warning on line 116 in modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp#L116 

class member 'VoltagePlausibilityMonitor::timer_std_deviation_snapshot_' is never used.

Check warning on line 118 in modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp#L118 

class member 'VoltagePlausibilityMonitor::timer_armed_' is never used.

Check warning on line 119 in modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/EVSE/EvseManager/voltage_plausibility/VoltagePlausibilityMonitor.hpp#L119 

class member 'VoltagePlausibilityMonitor::timer_thread_exit_' is never used.
View more details on Codacy Production