feat(voltage_plausibility_monitor): Voltage plausibility check during DC charging to detect configuration of hardware inconsistencies #1711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florinmihut
requested review from
Pietfried,
SebaLukas,
andistorm,
corneliusclaussen,
djchhp,
hikinggrass,
james-ctc and
mlitre
as code owners
Signed-off-by: Florin Mihut <[email protected]>
Signed-off-by: Florin Mihut <[email protected]>
florinmihut
force-pushed
the
feat/voltage_plausibility_monitor
branch
from
42840ce to
f550ae1
Compare
Pietfried
requested changes
Jan 16, 2026
Contributor
Pietfried
left a comment
Pietfried
left a comment
There was a problem hiding this comment.
See some comments in line. Please also add tests for the VoltagePlausibilityMonitor. These can be similar to e.g. https://github.com/EVerest/everest-core/blob/main/modules/EVSE/EvseManager/tests/OverVoltageMonitorTest.cpp
| {"evse_manager/MREC22ResistanceFault", "CX022"}, | ||
| {"evse_manager/MREC11CableCheckFault", "CX011"}, | ||
| {"evse_manager/MREC5OverVoltage", "CX005"}, | ||
| {"evse_manager/VoltagePlausibilityFault", ""}, |
Contributor
There was a problem hiding this comment.
Since this doesn't map to any MREC it is not required here
| {"evse_manager/MREC22ResistanceFault", {ocpp::v16::ChargePointErrorCode::OtherError, "CX022"}}, | ||
| {"evse_manager/MREC11CableCheckFault", {ocpp::v16::ChargePointErrorCode::OtherError, "CX011"}}, | ||
| {"evse_manager/MREC5OverVoltage", {ocpp::v16::ChargePointErrorCode::OverVoltage, "CX005"}}, | ||
| {"evse_manager/VoltagePlausibilityFault", {ocpp::v16::ChargePointErrorCode::OtherError, ""}}, |
| } | ||
|
|
||
| void VoltagePlausibilityMonitor::evaluate_voltages() { | ||
| // Check running state and fault latch (these are only modified from main thread, so no mutex needed here) |
Contributor
There was a problem hiding this comment.
To me it looks like this is not correct, because trigger_fault is called from the timer thread. You can either make running_ and fault_latched_ atomic or protect them using the data_mutex_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds a voltage plausibility check during DC charging to detect inconsistencies between voltage measurements from multiple sources.
Monitors voltage from 4 sources:
Calculates standard deviation between available sources and compares it to a configurable threshold.
Raises a fault if the standard deviation value exceeds the threshold for a configurable duration, trying to prevent false positives from brief spikes.
Handles missing or stale data:
Configuration:
voltage_plausibility_std_deviation_threshold_V: Maximum allowed standard deviation (default: 50.0 V)
voltage_plausibility_fault_duration_ms: Duration SD must exceed threshold before fault (default: 10000 ms)
voltage_plausibility_measurement_max_age_ms: Maximum age of measurements before considered stale (default: 3000 ms)
Implementation
New VoltagePlausibilityMonitor class following the same pattern as OverVoltageMonitor
New error type: evse_manager/VoltagePlausibilityFault (High severity)
This helps detect configuration or hardware issues by comparing voltage readings from independent sources.
Issue ticket number and link
Checklist before requesting a review