Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#7303: Copy common, drsyscall, framework, wininc from drmemory to dynamorio/ext #7389

Merged

Conversation

ivankyluk
Copy link
Contributor

@ivankyluk ivankyluk commented Mar 20, 2025

Copy the following directories from drmemory to dynamorio

drmemory/common to dynamorio/ext/drmf/common (only files required for drsyscall are copied)
drmemory/drsyscall to dynamorio/ext/drsyscall
drmemory/framework to dynamorio/ext/drmf/framework
drmemory/wininc to dynamorio/ext/drmf/wininc
Remove empty lines before EOF and tabs in some of the files.

Format checks are disabled by adding DISABLE_FORMAT_CHECKS as a commit message (Ref #7361).

Add new files to make/style_checks/exclude to skip vera tests. The exclusion list does not take regular expressions.
I tried the following:

set drsyscall_files {}
foreach drsyscall_file [glob ../ext/drmf/common/*] {
    lappend drsyscall_files [file tail $drsyscall_file]
}

which works for all workflows but ci-aarchxx.yml. make/style_checks/exclude is run under /dynamorio/build_*, for example,

  • dynamorio/build_riscv64-debug-internal for ci-riscv64.yml
  • dynamorio/build_debug-internal-64 for ci-x86.yml

For ci-aarchxx.yml, it runs under dynamorio/build/build_debug-internal-64.

For the glob to work, it needs to be "../../ext/drmf/common/" for ci-aarchxx.yml, and " ../ext/drmf/common/" for the rest.

Consider the list is temporary until a follow up PR addresses the formatting issue, I use a list for the files under ext/drmf and ext/drsyscall.

Issue: #7303

@ivankyluk ivankyluk requested a review from derekbruening March 20, 2025 23:52
@derekbruening
Copy link
Contributor

It still says it's a draft?

@ivankyluk ivankyluk marked this pull request as ready for review March 21, 2025 15:51
@ivankyluk ivankyluk merged commit 099cb99 into master Mar 21, 2025
24 checks passed
@ivankyluk ivankyluk deleted the i7303-copy-drmemory-drsyscall-to-dynamorio-exclude-vera branch March 21, 2025 16:35
ivankyluk added a commit that referenced this pull request Mar 26, 2025
#7389  was based on DrMemory code base prior to DynamoRIO/drmemory#2546

This PR ports DrMemory PR2546 over to DynamoRIO.

Issue:: #7303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants