i#7303: Copy common, drsyscall, framework, wininc from drmemory to dynamorio/ext #7389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy the following directories from drmemory to dynamorio
drmemory/common to dynamorio/ext/drmf/common (only files required for drsyscall are copied)
drmemory/drsyscall to dynamorio/ext/drsyscall
drmemory/framework to dynamorio/ext/drmf/framework
drmemory/wininc to dynamorio/ext/drmf/wininc
Remove empty lines before EOF and tabs in some of the files.
Format checks are disabled by adding DISABLE_FORMAT_CHECKS as a commit message (Ref #7361).
Add new files to make/style_checks/exclude to skip vera tests. The exclusion list does not take regular expressions.
I tried the following:
which works for all workflows but ci-aarchxx.yml. make/style_checks/exclude is run under /dynamorio/build_*, for example,
For ci-aarchxx.yml, it runs under dynamorio/build/build_debug-internal-64.
For the glob to work, it needs to be "../../ext/drmf/common/" for ci-aarchxx.yml, and " ../ext/drmf/common/" for the rest.
Consider the list is temporary until a follow up PR addresses the formatting issue, I use a list for the files under ext/drmf and ext/drsyscall.
Issue: #7303