i#7303: Copy drsyscall from drmemory to dynamorio/ext. #7304

ivankyluk · 2025-02-25T21:30:40Z

Copy files from drmemory/drsyscall to dynamorio/ext/drsyscall. Files required by drsyscall under drmemory/common and drmemory/framework are copied as well.

The following changes are made:

Add drcontext as the first parameter to LOG(...)
Remove rlimit64 declaration from linux_defines.h.
Remove IF_WINDOWS_ELSE from common/utils.h
Change op_verbose_level to verbose in common/utils.h
LOG if DEBUG is defined to remove drcontext
Update drsyscall/CMakeLists.txt to include files in framework and common.
Copy the DRMF_VERSION and set_library_version logic from drmemory/CMakeLists.txt to ext/drsyscall/CMakeList.txt.
Add a space in between "while(" for REPORT_DISK_ERROR in common/utils.h.
(MacOS) Comment out SYS_nfsclnt, SYS___old_semwait_signal, SYS___old_semwait_signal_nocancel and SYS_shared_region_map_and_slide_np in table_macos_bsd.c (xref macOS Ventura support drmemory#2483).
Skip Alpine, ANDROID and RISCV64 build in drsycall/CMakeLists.txt
Change make/resources.rc to core/win32/resources.rc in drsyscall/CMakeLists.txt.
Remove empty lines before EOF and change tabs to spaces in files.

Issue: #7303

…ult.

…signal_nocancel and SYS_shared_region_map_and_slide_np.

…/syscall.h.

…eLists.txt.

…UNIX.

…able.

…mit messages. (#7345) Skip clang-format checks and vera test if DISABLE_FORMAT_CHECKS appears in one of the commit messages. This feature enables us to copy code over without format changes as a base line and use subsequent PRs to fix format issues. And it is useful to add .patch files or other files where tabs are part of the format. Format checks can also be disabled by setting DISABLE_FORMAT_CHECKS to ON, for example, cmake -DDISABLE_FORMAT_CHECKS=ON ... Test: I added DISABLE_FORMAT_CHECKS as part of a commit message to #7304 and verified format checks were disabled except aarch64 build. "gh api" is not installed on the aarchxx machines. Adding "gh" to the install list didn't work, and manually installing gh or github-cli failed using tmate. I have added a TODO in .github/workflows/ci-aarchxx.yml to add the support once "gh api" is installed. Issue: #7344

…mit messages. (#7361) Skip clang-format, vera and tab checks if DISABLE_FORMAT_CHECKS appears in one of the commit messages. This feature enables us to copy code over without format changes as a base line and use subsequent PRs to fix format issues. And it is useful to add .patch files or other files where tabs are part of the format. Format checks can also be disabled by setting DISABLE_FORMAT_CHECKS to ON, for example, cmake -DDISABLE_FORMAT_CHECKS=ON ... Test: I added DISABLE_FORMAT_CHECKS as part of a commit message to #7304 and verified format checks were disabled except aarch64 build. "gh api" is not installed on the aarchxx machines. Adding "gh" to the install list didn't work, and manually installing gh or github-cli failed using tmate. I have added a TODO in .github/workflows/ci-aarchxx.yml to add the support once "gh api" is installed. The original PR #7345 was reverted because github.event.pull_request._links.commits.href is absent in case of push/merge. This PR handles the push/merge case by using ``` if ${{ contains(toJSON(github.event.commits.*.message), 'DISABLE_FORMAT_CHECKS') }} ``` for push. Test: - I added DISABLE_FORMAT_CHECKS as part of a commit message in a clone repository, ivankyluk/dynamorio, to verify format checks were disable when DISABLE_FORMAT_CHECKS was added as a commit message. And formats checks were enabled when DISABLE_FORMAT_CHECKS was absent. - I used the cloned repository to test the push/merge event. Issue: #7344

ivankyluk · 2025-03-26T17:04:49Z

Copying DrSyscall from DrMemory to DynamoRIO is done by #7389, #7393, and #7396.

…leases. (#7425) Syscall statx was introduced in Linux Kernel 4.11. struct statx and statx_timestamp are not defined in older versions. Define the structs in core/unix/include/stat.h and use the header file instead of linux/stat.h. Issue: #7304

ivankyluk added 4 commits February 25, 2025 12:47

i7303: Copy drsyscall from drmemory to drnamorio/ext.

849a82a

Update copyrights.

22e5eb6

Remove framework/CMakeLists.txt.

2b62f8e

Add clang-format off.

890b4fe

ivankyluk changed the title ~~i7303: Copy drsyscall from drmemory to drnamorio/ext.~~ i7303: Copy drsyscall from drmemory to dynamorio/ext. Feb 25, 2025

ivankyluk added 10 commits February 25, 2025 15:43

Remove clang-format off and disable tab check in runsuite.cmake.

4c17a47

Disable format check.

0aa5889

Insert a space between while and ( in common/utils.h

5b4f96f

Move common/ and framework/ from ext/ to ext/drmf/.

c8cfc4a

Change max line length to 900 for tests.

ee5d37d

Suspend style checks.

cdace28

Put back space after call check.

cf39a5b

Cleanup make/style_checks/exclude and make/style_checks/profiles/defa…

4eae62c

…ult.

Skip drsyscall for RISCV64.

814df5a

Comment out SYS_nfsclnt, SYS___old_semwait_signal, SYS___old_semwait_…

47a42c2

…signal_nocancel and SYS_shared_region_map_and_slide_np.

ivankyluk changed the title ~~i7303: Copy drsyscall from drmemory to dynamorio/ext.~~ i#7303: Copy drsyscall from drmemory to dynamorio/ext. Feb 26, 2025

ivankyluk added 14 commits February 26, 2025 15:01

Skip drsyscall Aarch64 build until asm_utils_aarch64.asm is added.

d12d1b3

Revert back to use common/sysnum_linux.h instead of core/unix/include…

f74c4a9

…/syscall.h.

Change make/resources.rc to core/win32/resources.rc in drsyscall/CMak…

98e8bf4

…eLists.txt.

Add drmf/common/windefs.h

40fa7f8

Add CLONE_* define to drsyscall_os.h.

b1b0f48

Add CLONE_* define to drsyscall_os.h.

3906273

Copy drmemory/wininc to dynamorio/ext/drmf/wininc.

98106d5

Skip ANDROID build for drsyscall.

8c8fe14

Add dependency for asm build and remove define for CLONE_*.

5579c16

Skip Alpine build for drsyscall and restore append_property_list for …

0fb9172

…UNIX.

Windows: change cmake warning flag from W4 to W2.

415fdc9

Add drcontext to LOG(), cast pointer subtraction to size_t.

b44a733

Fix the warning change, and add -DASSEMBLE_WITH_MASM.

9f5d719

Replace W4 with W2 under if (WIN32).

8d8cbb1

ivankyluk added 4 commits March 11, 2025 15:43

Remove quote around yes/no.

ca6789f

Add id to all the check clang format steps.

120f87e

.github/workflows/ci-x86.yml

a6080b5

Add clang-format check to windows, fix alpine clang-format check vari…

2a180ff

…able.

This was referenced Mar 11, 2025

Skip format checks if DISABLE_FORMAT_CHECKS appears in one of the commit messages #7344

Closed

i#7344: Skip format checks if DISABLE_FORMAT_CHECKS is present in commit messages. #7345

Merged

ivankyluk added 3 commits March 11, 2025 17:15

Remove redundant set(ENV{DISABLE_CLANG_FORMAT_CHECKS}).

c0484a4

Move the format check before Creat Build Environment.

61d14d1

add tmate to debug which files can't be removed.

b72fdfd

ivankyluk added 11 commits March 13, 2025 10:26

Use github.event.number to pull the commit messages.

3fe6cfd

Change / to .

03709db

Remove '' around web link and add tmate.

9a2a05e

Handle pull event separately.

a2c0d38

Fix if-elif syntax.

d765b3e

Add the missing done for for-loop.

c050c4b

Change = to ==; DISABLE_FORMAT_CHECKS

40e6287

Fix the if check.

ca63289

Another attempt to fix the if check.

5fbd2fb

fix the x86 workflow.

a7cb3ad

Remove uses from the clang-format check step.

ea46f6f

ivankyluk mentioned this pull request Mar 14, 2025

i#7344: Skip format checks if DISABLE_FORMAT_CHECKS is present in commit messages. #7361

Merged

ivankyluk added 3 commits March 21, 2025 09:03

Add debug to make/style_checks/exclude.

ab9351c

Restore ci-docs.yml and ci-package.yml.

f6dd182

Merge branch 'master' into i7303-copy-drsyscall-to-dynamorio-ext

d68241a

ivankyluk closed this Mar 26, 2025

ivankyluk mentioned this pull request Apr 2, 2025

i#7303 drsyscall: Define statx and statx_timestamp for older Linux releases. #7425

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

i#7303: Copy drsyscall from drmemory to dynamorio/ext. #7304

i#7303: Copy drsyscall from drmemory to dynamorio/ext. #7304

ivankyluk commented Feb 25, 2025 •

edited

Loading

ivankyluk commented Mar 26, 2025

i#7303: Copy drsyscall from drmemory to dynamorio/ext. #7304

i#7303: Copy drsyscall from drmemory to dynamorio/ext. #7304

Conversation

ivankyluk commented Feb 25, 2025 • edited Loading

ivankyluk commented Mar 26, 2025

ivankyluk commented Feb 25, 2025 •

edited

Loading