Skip to content

chore: wrap open feature reason in debug #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025
Merged

chore: wrap open feature reason in debug #247

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
538e198
chore: wrap openFeatureEvalReason in #if DEBUG flag to only be availa…
kaushalkapasi Jul 17, 2025
d1be869
chore: rename debug openFeatureEvalReason method to createOFEvalReason
kaushalkapasi Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions DevCycle/Models/UserConfig.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,11 @@ public struct EvalReason {
return EvalReason(reason: "DEFAULT", details: details)
}

public static func openFeatureEvalReason(reason: String) -> EvalReason {
return EvalReason(reason: reason, details: "")
#if DEBUG
Copy link
Member

@jonathannorris jonathannorris Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there not #if TEST?

Copy link
Collaborator Author

@kaushalkapasi kaushalkapasi Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not built in, it would require a custom implementation. Using #if DEBUG is recommend, since it works for all Debug builds (and is automatically set as part of the build stages in Xcode / command line)

public static func createOFEvalReason(reason: String) -> EvalReason {
return EvalReason(reason: reason, details: "OpenFeature Testing")
}
#endif
}

public typealias EvalMetaData = [String: Any]
Expand Down
Loading