chore: wrap open feature reason in debug #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR renames a static method and restricts its usage to debug builds only.
- Renames
openFeatureEvalReasontocreateOFEvalReason - Wraps
createOFEvalReasonin a#if DEBUGblock so it’s only available in Debug builds
Comments suppressed due to low confidence (2)
DevCycle/Models/UserConfig.swift:237
- [nitpick] Add a documentation comment explaining that
createOFEvalReasonis only available in debug builds and describe its intended purpose.
public static func createOFEvalReason(reason: String) -> EvalReason {
DevCycle/Models/UserConfig.swift:236
- Ensure there are unit tests covering
createOFEvalReasonin debug builds so its behavior remains validated.
#if DEBUG
|
|
||
| public static func openFeatureEvalReason(reason: String) -> EvalReason { | ||
| return EvalReason(reason: reason, details: "") | ||
| #if DEBUG |
Collaborator
Author
There was a problem hiding this comment.
not built in, it would require a custom implementation. Using #if DEBUG is recommend, since it works for all Debug builds (and is automatically set as part of the build stages in Xcode / command line)
jonathannorris
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openFeatureEvalReasonstatic method tocreateOFEvalReasoncreateOFEvalReasonin#if DEBUGto only allow the method to be used in Debug builds and not Release builds