refactor: consolidate duplicate fetchWithRetries utility #123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates the duplicate
fetchWithRetriesutility function into a single shared location, following the DRY (Don't Repeat Yourself) principle.Problem
The codebase had two identical copies of
fetchWithRetries.ts:src/app/employer/documents/fetchWithRetries.tssrc/app/employee/documents/fetchWithRetries.tsBoth files contained the exact same code (57 lines each), which:
Solution
Created a new shared utility at
src/lib/fetchWithRetries.tswith:Enhanced Features:
FetchWithRetriesOptionsinterfaceNew Configuration Options:
Changes
src/lib/fetchWithRetries.ts- New shared utility with enhanced featuressrc/app/employer/documents/page.tsx- Updated import pathsrc/app/employee/documents/page.tsx- Updated import pathsrc/app/employer/documents/fetchWithRetries.ts- Duplicate filesrc/app/employee/documents/fetchWithRetries.ts- Duplicate fileUsage Example
Breaking Changes
None - The existing API is preserved and works exactly as before.
Testing