Repository Reorganization #124
Conversation
Snakemake format
Lint all processing scripts
There was a problem hiding this comment.
This is a very comprehensive pull request, good job!
As we talked about, it probably should've been broken into at least two PR's, and the README's should really be updated alongside (to limit historical "broken" versions of the code on GitHub), but it looks good overall.
| @@ -0,0 +1,26 @@ | |||
| [metadata] | |||
| name = can_usa_scripts | |||
| version = 0.0.1 | |||
There was a problem hiding this comment.
We are currently not autoversioning, but it can seemingly be achieved with Git: https://stackoverflow.com/questions/37814286/how-to-manage-the-version-number-in-git. Do you think we should use versioning, either by updating this value or through a different method?
There was a problem hiding this comment.
Feel free to add as an issue. I don't think it is necessary for this pr tho?
There was a problem hiding this comment.
No, it's not necessary for this PR. Issue #128 created for looking into this.
In this pull request, I have:
workflow/scriptsas a package in preparation of adding in pytest functionalityworkflow/to follow pylint standards. Snakemake files passsnakemake --lintchecks*.smk) to follow snakemake's best practice guidelinesCanada-U.S.-ElecTrade/), the commandsnakemake data_file -c1now executes the workflowNo functional changes have been made to the model. The
CanadaUSA.txtdata file that the workflow produces has not changed with the updates