-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating CSM rules doc with policy info #27385
Open
michaelcretzman
wants to merge
8
commits into
master
Choose a base branch
from
mcretzman/DOCS-9749-csm-threats-multi-policy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+135
−58
Open
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7d04661
updating CSM rules doc with policy info
michaelcretzman a2ce1a0
added policy feature
michaelcretzman b86b449
Merge branch 'master' into mcretzman/DOCS-9749-csm-threats-multi-policy
michaelcretzman c12f821
Apply suggestions from code review
michaelcretzman 002e1e9
Apply suggestions from code review
michaelcretzman 0f5b3d7
incorporated peer edit suggestions
michaelcretzman 707d564
missed a peer edit comment
michaelcretzman 272fb0e
Merge branch 'master' into mcretzman/DOCS-9749-csm-threats-multi-policy
michaelcretzman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a clear sequence here where you create policies, then add rules, but the descriptions of both of those things bounce back and forth between the two a bit. Can we make the descriptions line up with the sequence a bit better here (that is, explain what a policy is and that you have to make one first, then explain what a rule is and talk about how it relates to policies)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the reason I did it this way was you can't explain that a policy is a collection of rules without first explaining what a rule is.