-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating CSM rules doc with policy info #27385
base: master
Are you sure you want to change the base?
updating CSM rules doc with policy info #27385
Conversation
We now group CSM Agent rules into policies. This doc update covers this new feature.
added new policy feature for CSM Threats Agent Configuration rules
Preview links (active after the
|
Ed review topic was created: https://datadoghq.atlassian.net/browse/DOCS-9980 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! just some nitpicks / questions
content/en/security/threats/workload_security_rules/custom_rules.md
Outdated
Show resolved
Hide resolved
content/en/security/threats/workload_security_rules/custom_rules.md
Outdated
Show resolved
Hide resolved
content/en/security/threats/workload_security_rules/custom_rules.md
Outdated
Show resolved
Hide resolved
content/en/security/threats/workload_security_rules/custom_rules.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incorp Eng review
content/en/security/threats/workload_security_rules/custom_rules.md
Outdated
Show resolved
Hide resolved
content/en/security/threats/workload_security_rules/custom_rules.md
Outdated
Show resolved
Hide resolved
content/en/security/threats/workload_security_rules/custom_rules.md
Outdated
Show resolved
Hide resolved
content/en/security/threats/workload_security_rules/custom_rules.md
Outdated
Show resolved
Hide resolved
content/en/security/threats/workload_security_rules/custom_rules.md
Outdated
Show resolved
Hide resolved
content/en/security/threats/workload_security_rules/custom_rules.md
Outdated
Show resolved
Hide resolved
incorp Eng review feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Michael, looks great! I had some questions about the structure of the page, and then a small typo change. Let me know if there's anything you'd like to chat about, or if you'd like me to take another look, or any other way I can help 🙂
In addition to the out of the box (OOTB) [default Agent and detection rules][7], you can write custom Agent and detection rules. Custom rules help to detect events Datadog is not detecting with its OOTB rules. | ||
|
||
Agent rules are collected in policies. First, you create a policy, and then you add the custom rules you want applied by the policy. | ||
|
||
When you create an Agent configuration policy it contains the default rules only. You can add custom rules to the policy to target specific infrastructure locations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a clear sequence here where you create policies, then add rules, but the descriptions of both of those things bounce back and forth between the two a bit. Can we make the descriptions line up with the sequence a bit better here (that is, explain what a policy is and that you have to make one first, then explain what a rule is and talk about how it relates to policies)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the reason I did it this way was you can't explain that a policy is a collection of rules without first explaining what a rule is.
content/en/security/threats/workload_security_rules/custom_rules.md
Outdated
Show resolved
Hide resolved
content/en/security/threats/workload_security_rules/custom_rules.md
Outdated
Show resolved
Hide resolved
content/en/security/threats/workload_security_rules/custom_rules.md
Outdated
Show resolved
Hide resolved
content/en/security/threats/workload_security_rules/custom_rules.md
Outdated
Show resolved
Hide resolved
content/en/security/threats/workload_security_rules/custom_rules.md
Outdated
Show resolved
Hide resolved
content/en/security/threats/workload_security_rules/custom_rules.md
Outdated
Show resolved
Hide resolved
incorp edit review changes. still a few more to do but need to do them locally Co-authored-by: Janine Chan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incorp edit review
content/en/security/threats/workload_security_rules/custom_rules.md
Outdated
Show resolved
Hide resolved
content/en/security/threats/workload_security_rules/custom_rules.md
Outdated
Show resolved
Hide resolved
In addition to the out of the box (OOTB) [default Agent and detection rules][7], you can write custom Agent and detection rules. Custom rules help to detect events Datadog is not detecting with its OOTB rules. | ||
|
||
Agent rules are collected in policies. First, you create a policy, and then you add the custom rules you want applied by the policy. | ||
|
||
When you create an Agent configuration policy it contains the default rules only. You can add custom rules to the policy to target specific infrastructure locations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the reason I did it this way was you can't explain that a policy is a collection of rules without first explaining what a rule is.
We now group CSM Agent rules into policies. This doc update covers this new feature.