-
Notifications
You must be signed in to change notification settings - Fork 62
Enhancement standalone type uint8 #1900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: standalone-scheme-types
Are you sure you want to change the base?
Enhancement standalone type uint8 #1900
Conversation
4627031 to
ae47355
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## standalone-scheme-types #1900 +/- ##
========================================================
Coverage 76.15% 76.15%
========================================================
Files 103 103
Lines 19423 19424 +1
========================================================
+ Hits 14791 14792 +1
Misses 4632 4632 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f219b33 to
2fd0b6a
Compare
ae57747 to
c5e2676
Compare
| using t8_element_type = std::bitset<T8_ELEMENT_NUM_EQUATIONS[TEclass]>; | ||
| //template <t8_eclass TEclass> | ||
| //using t8_element_type = std::bitset<T8_ELEMENT_NUM_EQUATIONS[TEclass]>; | ||
| //using t8_element_type = u_int8_t; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you not using this line? It would add a little bit of context to the data-type, especially when it is used as return-type.
|
|
||
| template <t8_eclass TEclass> | ||
| using t8_element_type = std::bitset<T8_ELEMENT_NUM_EQUATIONS[TEclass]>; | ||
| //template <t8_eclass TEclass> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't use these lines, please delete them.
Describe your changes here:
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).