Skip to content

Enhancement standalone type uint8 #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukasdreyer wants to merge 5 commits into
base: standalone-scheme-types
Choose a base branch
from
Open

Enhancement standalone type uint8 #1900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e653fc3
change type to uint8, compute ancestorid correctly
lukasdreyer Oct 21, 2025
a7640c2
fix assertion
lukasdreyer Oct 21, 2025
d0ad701
Only look at type when it is allowed to
lukasdreyer Oct 22, 2025
2fd0b6a
fix type access
lukasdreyer Oct 22, 2025
c5e2676
Do not use type for hypercubes
lukasdreyer Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/t8_schemes/t8_standalone/t8_standalone_elements.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,9 @@ typedef uint8_t t8_element_level;
typedef uint8_t t8_cube_id;
typedef uint8_t t8_child_id;

template <t8_eclass TEclass>
using t8_element_type = std::bitset<T8_ELEMENT_NUM_EQUATIONS[TEclass]>;
//template <t8_eclass TEclass>
Copy link
Collaborator

@Davknapp Davknapp Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't use these lines, please delete them.

//using t8_element_type = std::bitset<T8_ELEMENT_NUM_EQUATIONS[TEclass]>;
//using t8_element_type = u_int8_t;
Copy link
Collaborator

@Davknapp Davknapp Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you not using this line? It would add a little bit of context to the data-type, especially when it is used as return-type.


template <t8_eclass TEclass>
using t8_element_coords = std::array<t8_element_coord, T8_ELEMENT_DIM[TEclass]>;
Expand All @@ -168,7 +169,7 @@ struct t8_standalone_element
/** The refinement level of the element relative to the root at level 0. */
t8_element_level level;
/** Bit array: which inequality is fulfilled at which level. */
t8_element_type<TEclass> type;
u_int8_t type;
};

#endif /* T8_STANDALONE_ELEMENTS_HXX */
Loading