Skip to content

chore: upgrade favicons, fix codecov yml #7955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 30 additions & 8 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version: 2.1

orbs:
codecov: codecov/codecov@3.2.5
codecov: codecov/codecov@5.4.3

executors:
node:
Expand Down Expand Up @@ -229,6 +229,23 @@ commands:
no_output_timeout: 5m
command: until [ -f coverage/coverage.xml ]; do sleep 1; done

upload_coverage_report:
steps:
- run:
name: Assign unique coverage filename
command: |
mv coverage/coverage.xml coverage/cov-<< parameters.prefix >>-${CIRCLE_NODE_INDEX}.xml
stat coverage/cov-<< parameters.prefix >>-${CIRCLE_NODE_INDEX}.xml

- codecov/upload:
upload_name: << parameters.prefix >>-${CIRCLE_NODE_INDEX}
files: coverage/cov-<< parameters.prefix >>-${CIRCLE_NODE_INDEX}.xml
flags: backend

parameters:
prefix:
type: string

setup_docker_layer_cache:
steps:
- setup_remote_docker:
Expand Down Expand Up @@ -275,6 +292,14 @@ jobs:
- serve_rails_server
- build_and_run_auth_server

# Replace both archive and security repositories
# https://support.circleci.com/hc/en-us/articles/37474192881179-Resolving-Unable-to-connect-to-archive-ubuntu-com-Error-in-CircleCI
- run:
name: Change Ubuntu archive mirrors
command: |
sudo sed -i 's|http://archive.ubuntu.com|http://mirrors.rit.edu|g' /etc/apt/sources.list
sudo sed -i 's|http://security.ubuntu.com|http://mirrors.rit.edu|g' /etc/apt/sources.list

- run:
name: Install Playwright dependencies
working_directory: tests
Expand All @@ -294,6 +319,8 @@ jobs:
command: yarn coverage

- terminate_rails_and_wait_for_coverage_results
- upload_coverage_report:
prefix: playwright-rails

- run:
name: Zip test results
Expand All @@ -302,10 +329,6 @@ jobs:
command: |
zip -r test-results.zip test-results playwright-report

- codecov/upload:
upload_name: playwright-rails
file: coverage/coverage.xml

- store_test_results:
path: ~/repo/tests/results.xml

Expand Down Expand Up @@ -340,9 +363,8 @@ jobs:
mkdir ~/rspec
circleci tests glob "spec/**/*_spec.rb" | circleci tests run --command="xargs bundle exec rspec --format progress --format RspecJunitFormatter -o ~/rspec/rspec.xml" --verbose --split-by=timings

- codecov/upload:
upload_name: rspec-rails
file: coverage/coverage.xml
- upload_coverage_report:
prefix: rspec-rails

- store_test_results:
path: ~/rspec
Expand Down
6 changes: 4 additions & 2 deletions .codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,13 @@ coverage:
frontend:
target: auto
threshold: 0.1%
flags: frontend
flags:
- frontend
backend:
target: auto
threshold: 0.1%
flags: backend
flags:
- backend
patch: yes
changes: no

Expand Down
7 changes: 4 additions & 3 deletions client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@
"eslint-plugin-react-hooks": "^4.6.2",
"eslint-plugin-simple-import-sort": "^12.1.0",
"eslint-plugin-sonarjs": "^0.24.0",
"favicons": "^7.1.4",
"favicons": "^7.2.0",
"favicons-webpack-plugin": "^6.0.1",
"fork-ts-checker-webpack-plugin": "^9.0.2",
"html-webpack-plugin": "^5.6.0",
Expand All @@ -190,7 +190,7 @@
"redux-logger": "^3.0.6",
"sass": "^1.76.0",
"sass-loader": "^14.1.0",
"sharp": "^0.34.1",
"sharp": "^0.34.2",
"style-loader": "^3.3.4",
"svgo": "^3.3.2",
"tailwindcss": "^3.4.1",
Expand All @@ -203,7 +203,8 @@
"webpack-merge": "^5.10.0"
},
"resolutions": {
"cheerio": "1.0.0-rc.10"
"cheerio": "1.0.0-rc.10",
"sharp": "^0.34.2"
},
"license": "MIT",
"firstBuildYear": 2013,
Expand Down
Loading