chore: upgrade favicons, fix codecov yml #7955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adi-herwana-nus
force-pushed
the
adi/upgrade-favicons
branch
2 times, most recently
from
8952eab to
2f90b91
Compare
adi-herwana-nus
force-pushed
the
adi/upgrade-favicons
branch
5 times, most recently
from
cd9acf0 to
bd4a039
Compare
cysjonathan
approved these changes
May 28, 2025
adi-herwana-nus
force-pushed
the
adi/upgrade-favicons
branch
from
bd4a039 to
32f3110
Compare
- force resolution of sharp to ^0.34.2 to prevent conflicts
adi-herwana-nus
force-pushed
the
adi/upgrade-favicons
branch
3 times, most recently
from
ba55d76 to
96be5e8
Compare
adi-herwana-nus
force-pushed
the
adi/upgrade-favicons
branch
from
96be5e8 to
5b722e5
Compare
cysjonathan
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the security alerts related to
tar-fspackage (it's a nested dependency of favicons, which are resolved by upgrading minor version)Need to force the sharp dependency to resolve to
^0.34.2, since multiple conflicting versions of sharp causes build errors.While investigating recent coverage drops, I noticed that attempting to download the coverage report from Codecov returned a 404 error. Upgrading the Codecov CircleCI orb resolved this issue.
Note
The report file downloaded from Codecov is compressed using zstd. To uncompress, run the following commands
I updated the configuration to ensure each parallel test shard generates a uniquely named report (file and upload_name), which should prevent them from overwriting each other.
Although this doesn't directly fix the underlying drop in reported coverage, once this PR is merged, the individual reports will be correctly uploaded and downloadable. This will allow us to manually re-combine and analyze them if needed.
Update: CircleCI recently released this advisory on connection problems to ubuntu archives.
https://support.circleci.com/hc/en-us/articles/37474192881179-Resolving-Unable-to-connect-to-archive-ubuntu-com-Error-in-CircleCI
In our case, this affects the
yarn installstep of our Playwright tests.A commit has been pushed containing the workaround.
Confirmed that RIT (Rochester Institute of Technology) mirror works for our CircleCI tests.
https://app.circleci.com/pipelines/github/Coursemology/coursemology2/18339/workflows/f63bcf33-2ba6-491c-b367-79f931a792b9