Fix movement for Push Block + other additions #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework the function that moves the block by calling a different method. Added the "legacy" option for backwards compatibility. This fixes a bug where the block travels further when pushed in one direction compared to the other, i.e. further to the left than to the right, further upwards than downwards. This also makes the block fall at the same speed as a Falling Block. As this fix is only effective as long as "legacy" is off, it should not affect any Push Blocks that have already been placed. Other additions include: - support for custom textures - small tweaks to debris and particle generation
catapillie
requested changes
Apr 23, 2024
Co-authored-by: catapillie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the function that moves the block by calling a different method. Added the "legacy" option for backwards compatibility.
This fixes a bug where the block travels further when pushed in one direction compared to the other, i.e. further to the left than to the right, further upwards than downwards. This also makes the block fall at the same speed as a Falling Block.
As this fix is only effective as long as "legacy" is off, it should not affect any Push Blocks that have already been placed.
Other additions include:
Please let me know your thoughts on this. I'm especially wondering if small particle tweaks need to be toggled off by "legacy" or not