-
Notifications
You must be signed in to change notification settings - Fork 4
Bump node, bump tinybench, and add support of walltime runs for tinybench #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bump node, bump tinybench, and add support of walltime runs for tinybench #48
Conversation
59f5f8c
to
b1db2f2
Compare
CodSpeed Instrumentation Performance ReportMerging #48 will degrade performances by 96.36%Comparing Summary
Benchmarks breakdown
|
065360b
to
21234dd
Compare
CodSpeed WallTime Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
62e121a
to
9db57da
Compare
Node 22 failed because of a rollup issue regarding assert keyword that I was not able to fix yet 20.5.1 is chosen because of this: egoist/esbuild-register#96 This prevents us from running our examples easily
9db57da
to
2b1bdc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Really eager to release this
My two cents on the node issues: since you're at it, might be best to move away from esbuild-register, seems it's not maintained anymore? https://github.com/egoist/esbuild-register/commits/dev/ |
That's the plan, but I ran into issues making tsx work under our valgrind instrumentation for now, and do not have time to deep dive yet. |
f000974
to
6129c06
Compare
tinybench v4 removed support for cjs, nothing much we can do, the future is now
6129c06
to
b94dd64
Compare
1944230
to
022c470
Compare
3086a30
to
940276b
Compare
Breaking: cjs support is dropped because tinybench itself does not support cjs anymore starting from v4.
940276b
to
bfb95e2
Compare
"type": "module"
causesSyntaxError: Cannot use import statement outside a module
in node >= 20.6.0 egoist/esbuild-register#96issues/5685#issuecomment-2379581091
Fix #44