Skip to content

Bump node and switch tinybench to vitest #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

GuillaumeLagrange
Copy link

No description provided.

Copy link

codspeed-hq bot commented Jul 23, 2025

CodSpeed Instrumentation Performance Report

Merging #47 will improve performances by 61.61%

Comparing tech-upgrades (e48ddb9) with main (6df11e8)

Summary

⚡ 2 improvements
✅ 51 untouched benchmarks
⁉️ 33 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_recursive_fibo_10 34.6 µs 21.4 µs +61.61%
test sync baz 100 22.8 µs 17.5 µs +30.36%
⁉️ RegExp#test 12.3 µs N/A N/A
⁉️ String#indexOf 10.3 µs N/A N/A
⁉️ long body 331.2 µs N/A N/A
⁉️ short body 101.7 µs N/A N/A
⁉️ short body 2 59.4 µs N/A N/A
⁉️ short body 3 59.3 µs N/A N/A
⁉️ short body 4 59.3 µs N/A N/A
⁉️ short body 5 59.3 µs N/A N/A
⁉️ long body 415.9 µs N/A N/A
⁉️ short body 134.4 µs N/A N/A
⁉️ switch 1 11.8 µs N/A N/A
⁉️ switch 2 12.3 µs N/A N/A
⁉️ fibo 10 37 µs N/A N/A
⁉️ fibo 15 285 µs N/A N/A
⁉️ long body 375.3 µs N/A N/A
⁉️ short body 133.7 µs N/A N/A
⁉️ end 135.4 µs N/A N/A
⁉️ one 119.8 µs N/A N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@GuillaumeLagrange GuillaumeLagrange force-pushed the tech-upgrades branch 3 times, most recently from cc06e7d to 53a85d2 Compare July 23, 2025 15:02
Node 22 failed because of a rollup issue regarding assert keyword that I
was not able to fix yet
20.5.1 is chosen because of this:
egoist/esbuild-register#96
This prevents us from running our examples easily
@GuillaumeLagrange GuillaumeLagrange force-pushed the tech-upgrades branch 2 times, most recently from 0b704b3 to 3bff9dd Compare July 23, 2025 16:07
@GuillaumeLagrange GuillaumeLagrange force-pushed the tech-upgrades branch 3 times, most recently from c567084 to 7569b4d Compare July 23, 2025 17:02
@Nerivec
Copy link

Nerivec commented Jul 23, 2025

FYI security advisory GHSA-fjxv-7rqg-78g4 on

form-data:
specifier: ^4.0.0
version: 4.0.0

@GuillaumeLagrange GuillaumeLagrange force-pushed the tech-upgrades branch 3 times, most recently from b87ac78 to dc63efb Compare July 24, 2025 08:21
@GuillaumeLagrange
Copy link
Author

@Nerivec thanks for the heads up! This will be handled in another PR, most likely #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants