Skip to content

Conversation

@GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Jul 20, 2025

Summary

None

Purpose of change

Two PRs were merged at once - one that added boomer_bile and boomer_bile_adv items #72271, and one that added uncrafting test #81830. Collision happened

Describe the solution

Add two items to good uncraft list

Describe alternatives you've considered

Some better way to catch pseudo items, tho reading definition of boomer_bile, i cannot see anything existing that can be used to detect it is being a pseudo item

{
"id": "boomer_bile",
"type": "ITEM",
"subtypes": [ "AMMO" ],
"name": { "str": "boomer bile", "//~": "NO_I18N" },
"description": { "str": "Boomer bile, if you see this it's a bug.", "//~": "NO_I18N" },
"weight": "3 g",
"volume": "250 ml",
"material": [ "water" ],
"symbol": "=",
"color": "pink",
"phase": "liquid",
"ammo_type": "bile",
"range": 4,
"count": 1,
"effects": [ "NEVER_MISFIRES", "BILE_JET", "BILE_STINK", "BILE_BLIND" ]
},

Testing

CI

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Code: Tests Measurement, self-control, statistics, balancing. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jul 20, 2025
@kevingranade kevingranade merged commit e0e9994 into master Jul 20, 2025
39 of 53 checks passed
@GuardianDll GuardianDll deleted the fix_1 branch July 20, 2025 16:00
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants