fix meat (caloric) density

[dynst]

Summary

Balance "More realistic meat calories"

Purpose of change

Uncooked meat realistically should have excess water weight and bulk removed in the cooking process.

Cooked meat should have much more calories per gram, but also its density is physically impossible right now #54811

And realistically speaking, cracklins shouldn't be almost 2x denser than water.

Describe the solution

Increase the volume of all cracklins, make them 4x less space efficient but with portions still divisible into 500 ml containers #81781

Increase the calories in cooked meat and raw meat and everything that inherits from them.

Fix the density of meat_cooked and the numerous items that copy-from inherit from it.

Increase the weight and volume of raw meat. Update all items that inherit from raw meat accordingly.

Make meat_cooked inherit from meat and use "relative" and "proportional" fields.

Describe alternatives you've considered

Increasing the weight of raw meat, but that involves recipe consistency checks again. #61746 (comment)

Decreasing the volume of cooked meat, but that's impossible because it has to exactly fit into sealed cans. #81781

Testing

Additional context

Raw meat used to also have the illogical density and weight of 296 grams that cooked meat currently still does, until raw meat was fixed in #61746

[GuardianDll]

I would prefer weight be untouched, as a lot of recipes are made based on the old weight, and instead would just reduce the calorie amount

[dynst]

I would prefer weight be untouched, as a lot of recipes are made based on the old weight, and instead would just reduce the calorie amount

Do you mean reduce the calories in raw meat, rather than make raw meat larger? Then calories would magically appear out of nothing when you cook it into cooked meat.

[GuardianDll]

Calories would not appear, in most cases, because the game, in most cases again, inherit the amount of calories of a final product from it's components, if item is crafted. There is also a test that ensures that default amount of calories matches the amount of calories that can be obtained via the recipe

But yeah it's probably a choice do you want to fight with recipes using incorrect amount of meat, or fight items not having a correct amount of calories

[dynst]

Simplified to just fixing the number of calories in a portion of meat, can this PR be backported to 0.I? Is there a way to request it from the migo-chan bot?

[GuardianDll]

Is there a reason to backport it? we limit it only to bugfixes, and meat calories fit it only very nominally in my eyes

[dynst]

we limit it only to bugfixes,

Is that actually true? #81649 doesn't say bugfixes only, it doesn't even give absolute rules at all, it's very flexible-sounding guidance.

Balance changes, such as adjusting item weights or spawn chances etc, is more likely to be fine as long as it's well vetted.

And the current test failure on this PR was fixed in #81926

[GuardianDll]

Need to rebase