Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ApplicationSection and RecurringReservation Pindora GraphQL info #1568

Open
wants to merge 5 commits into
base: add-series-pindora-info-to-admin-panel
Choose a base branch
from

Conversation

matti-lamppu
Copy link
Collaborator

@matti-lamppu matti-lamppu commented Feb 14, 2025

🛠️ Changelog

  • Add Pindora info to the application section and recurring reservation GraphQL types
  • Add new lookup properties to recurring reservations for determining their access type based on their reservations
  • Add new Pindora fields to admin panel

🧪 Test plan

  • Automated tests

🚧 Dependencies

  • None

🎫 Tickets

@matti-lamppu matti-lamppu added the feature Adds a new feature label Feb 14, 2025
@matti-lamppu matti-lamppu self-assigned this Feb 14, 2025
@matti-lamppu matti-lamppu force-pushed the series-pindora-graphql branch 4 times, most recently from e1d75b5 to e37e7ef Compare February 14, 2025 12:43
@matti-lamppu matti-lamppu marked this pull request as ready for review February 14, 2025 13:28
@matti-lamppu matti-lamppu force-pushed the add-series-pindora-info-to-admin-panel branch from fe6768d to efddad6 Compare February 17, 2025 06:39
@matti-lamppu matti-lamppu force-pushed the series-pindora-graphql branch from 79f50f9 to e195ab4 Compare February 17, 2025 06:39
Copy link

@vergama vergama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes, see comments

- Don't show info from reservations in application sections before
  they are sent
- Add series and reservation ids to validity lists for identifying
  which series and reservation they correspond to
- Filter out which reservations in series/sections need access codes
  in the PindoraClient
@matti-lamppu matti-lamppu requested a review from vergama February 17, 2025 11:34
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud



@freeze_time(local_datetime(2022, 1, 3))
def test_application_section__query__pindora_info__section_past(graphql):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do my eyes fail me or is this identical to the above test (apart from the name)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants