Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add series pindora info to admin panel #1559

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

matti-lamppu
Copy link
Collaborator

@matti-lamppu matti-lamppu commented Feb 13, 2025

🛠️ Changelog

  • Add access_type to reservations admin panel view
  • Add access_type filter to reservations admin panel view
  • Fetch Pindora info from series or allocation depending on the reservations relations
  • Add should_have_active_access_code lookup property to series and show it in admin panel
  • Show Pindora info for series in admin panel, fetching from the series or allocation depending on its relations
  • Reformat series admin panel view

🧪 Test plan

  • Automated tests

🚧 Dependencies

  • None

🎫 Tickets

@matti-lamppu matti-lamppu added the feature Adds a new feature label Feb 13, 2025
@matti-lamppu matti-lamppu self-assigned this Feb 13, 2025
@matti-lamppu matti-lamppu force-pushed the add-series-pindora-info-to-admin-panel branch from f4e5750 to 1049931 Compare February 13, 2025 12:09
@matti-lamppu matti-lamppu marked this pull request as ready for review February 13, 2025 12:13
Copy link

@vergama vergama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@matti-lamppu matti-lamppu force-pushed the add-series-pindora-info-to-admin-panel branch from 1049931 to fe6768d Compare February 14, 2025 11:21
@matti-lamppu matti-lamppu force-pushed the add-series-pindora-info-to-admin-panel branch from fe6768d to efddad6 Compare February 17, 2025 06:39
Comment on lines +174 to +175
allocation = self.instance.recurring_reservation.allocated_time_slot
section = allocation.reservation_unit_option.application_section
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have this helper: self.instance.actions.get_application_section()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants