feat: support of http-path multiaddresses
#116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 20, 2025 16:47
bajtos
previously requested changes
Feb 21, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
NikolasHaimerl
changed the title
http-path multiaddresseshttp-path multiaddresses
bajtos
reviewed
Feb 21, 2025
There was a problem hiding this comment.
Almost there!
Please see my comments below for what to improve.
On aside
The implementation in multiaddrToHttpUrl() is becoming a bit complex too my taste, but I think that's ok:
- The complexity is fully contained inside
multiaddrToHttpUrl(). This function is changed infrequently, so the complexity does not matter that much. - We have very high test coverage. It will be easy to refactor this function later because the tests will guide us and prevent regressions.
- The current implementation supports what we need right now, as demonstrated by the test cases.
Co-authored-by: Miroslav Bajtoš <[email protected]>
juliangruber
requested changes
Feb 23, 2025
Co-authored-by: Julian Gruber <[email protected]>
Co-authored-by: Julian Gruber <[email protected]>
Co-authored-by: Julian Gruber <[email protected]>
Co-authored-by: Julian Gruber <[email protected]>
juliangruber
requested changes
Feb 24, 2025
Co-authored-by: Julian Gruber <[email protected]>
Co-authored-by: Julian Gruber <[email protected]>
Co-authored-by: Julian Gruber <[email protected]>
|
@NikolasHaimerl unfortunately CI currently frequently fails, as IPNI is having issues :| |
|
I'm asking IPNI about it here: https://space-meridian.slack.com/archives/C02T827T9N0/p1740479104123989 |
juliangruber
dismissed
bajtos’s stale review
For some reason GitHub shows me that @bajtos requested changes, but I don't see any open change request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
http-pathmulti addresses inmultiaddrToHttpUrlhttp-pathlinkshttp-pathlinksImplementation Plan
Subtask of:
CheckerNetwork/roadmap#239
Related Issue:
CheckerNetwork/piece-indexer#117