Skip to content

feat: support for http-path multiaddr #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 26, 2025
Merged

feat: support for http-path multiaddr #131

merged 7 commits into from
Feb 26, 2025

Conversation

NikolasHaimerl
Copy link
Contributor

@NikolasHaimerl NikolasHaimerl commented Feb 25, 2025 •
edited
Loading

CHANGELOG

  1. Support for http-path in multiaddrToHttpUrl

The function multiaddrToHttpUrl inside of the piece indexer is copied over from the spark-checker repo. This function was recently updated in spark-checker. Now we also want to update it here.
The test added in this PR does not serve as extensive testing but rather a smoke test to show that errors are propagated up the stack as expected, similar to what we are already doing here. Extensive testing of the function multiaddrToHttpUrl is done in the spark-checker repo.

Related to #117
Loosely related to filcdn/roadmap#239

@NikolasHaimerl NikolasHaimerl marked this pull request as ready for review February 25, 2025 15:43
@NikolasHaimerl NikolasHaimerl merged commit de5009c into main Feb 26, 2025
10 checks passed
@NikolasHaimerl NikolasHaimerl deleted the nhaimerl-http-path-url-support branch February 26, 2025 08:34
pyropy pushed a commit that referenced this pull request Feb 26, 2025
@NikolasHaimerl @pyropy
feat: support for http-path multiaddr (#131)
3a9c768 
* copied mutliaddr func

* add test for malformed http-path address

* formatting

* fmt

* fmt

---------

Co-authored-by: Nikolas Haimerl <[email protected]>
pyropy added a commit that referenced this pull request Feb 26, 2025
@pyropy @juliangruber
@bajtos @dependabot @NikolasHaimerl
fix: Copy dependabot-auto-merge.yml (#130)
725aae9 
* Copy dependabot-auto-merge.yml script from core-fly

* add `CODEOWNERS` (#95)

* add `CODEOWNERS`

* Update .github/CODEOWNERS

---------

Co-authored-by: Miroslav Bajtoš <[email protected]>

* deps(dev): Bump @types/node from 22.10.7 to 22.10.9 (#96)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.10.7 to 22.10.9.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* deps: Bump @sentry/node from 8.50.0 to 8.51.0 (#97)

Bumps [@sentry/node](https://github.com/getsentry/sentry-javascript) from 8.50.0 to 8.51.0.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/8.51.0/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@8.50.0...8.51.0)

---
updated-dependencies:
- dependency-name: "@sentry/node"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): Bump node from 23.6.0-slim to 23.6.1-slim (#98)

Bumps node from 23.6.0-slim to 23.6.1-slim.

---
updated-dependencies:
- dependency-name: node
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* deps(dev): Bump @types/node from 22.10.9 to 22.10.10 (#99)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.10.9 to 22.10.10.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* api: add `fastify` (#94)

* api: add `fastify`

* clean up

* address related PR review

* deps(dev): Bump @types/node from 22.10.10 to 22.12.0 (#100)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.10.10 to 22.12.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix sentry fastify error reporting (#101)

Co-authored-by: Miroslav Bajtoš <[email protected]>

* deps: Bump @sentry/node from 8.51.0 to 8.52.0 (#103)

Bumps [@sentry/node](https://github.com/getsentry/sentry-javascript) from 8.51.0 to 8.52.0.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/8.52.0/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@8.51.0...8.52.0)

---
updated-dependencies:
- dependency-name: "@sentry/node"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: auto-approve more dependencies (#102)

```
- '@types/'
- prettier
- debug
```

Signed-off-by: Miroslav Bajtoš <[email protected]>

* deps(dev): Bump @types/node from 22.12.0 to 22.13.0 (#106)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.12.0 to 22.13.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* deps(dev): Bump @types/node from 22.13.0 to 22.13.1 (#110)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.13.0 to 22.13.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* deps: Bump @sentry/node from 8.52.0 to 8.54.0 (#109)

Bumps [@sentry/node](https://github.com/getsentry/sentry-javascript) from 8.52.0 to 8.54.0.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/8.54.0/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@8.52.0...8.54.0)

---
updated-dependencies:
- dependency-name: "@sentry/node"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* disable `CODEOWNERS` on pkg files (#104)

This allows auto merge to happen when github actions approves. https://github.com/orgs/community/discussions/23064

* deps: Bump ioredis from 5.4.2 to 5.5.0 (#112)

Bumps [ioredis](https://github.com/luin/ioredis) from 5.4.2 to 5.5.0.
- [Release notes](https://github.com/luin/ioredis/releases)
- [Changelog](https://github.com/redis/ioredis/blob/main/CHANGELOG.md)
- [Commits](redis/ioredis@v5.4.2...v5.5.0)

---
updated-dependencies:
- dependency-name: ioredis
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* deps: Bump @sentry/node from 8.54.0 to 9.0.0 (#113)

Bumps [@sentry/node](https://github.com/getsentry/sentry-javascript) from 8.54.0 to 9.0.0.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/develop/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@8.54.0...9.0.0)

---
updated-dependencies:
- dependency-name: "@sentry/node"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* deps(dev): Bump prettier from 3.4.2 to 3.5.0 (#111)

Bumps [prettier](https://github.com/prettier/prettier) from 3.4.2 to 3.5.0.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.4.2...3.5.0)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): Bump node from 23.6.1-slim to 23.7.0-slim (#108)

Bumps node from 23.6.1-slim to 23.7.0-slim.

---
updated-dependencies:
- dependency-name: node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* deps: Bump @sentry/node from 9.0.0 to 9.0.1 (#115)

Bumps [@sentry/node](https://github.com/getsentry/sentry-javascript) from 9.0.0 to 9.0.1.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/develop/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@9.0.0...9.0.1)

---
updated-dependencies:
- dependency-name: "@sentry/node"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: auto-approve Node.js minor/patch updates (#114)

Signed-off-by: Miroslav Bajtoš <[email protected]>

* deps(dev): Bump @types/node from 22.13.1 to 22.13.2 (#120)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.13.1 to 22.13.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* deps(dev): Bump @types/node from 22.13.2 to 22.13.4 (#121)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.13.2 to 22.13.4.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* deps(dev): Bump prettier from 3.5.0 to 3.5.1 (#123)

Bumps [prettier](https://github.com/prettier/prettier) from 3.5.0 to 3.5.1.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.5.0...3.5.1)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* deps: Bump @sentry/node from 9.0.1 to 9.1.0 (#122)

Bumps [@sentry/node](https://github.com/getsentry/sentry-javascript) from 9.0.1 to 9.1.0.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/9.1.0/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@9.0.1...9.1.0)

---
updated-dependencies:
- dependency-name: "@sentry/node"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): Bump node from 23.7.0-slim to 23.8.0-slim (#124)

Bumps node from 23.7.0-slim to 23.8.0-slim.

---
updated-dependencies:
- dependency-name: node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* deps: Bump multiformats from 13.3.1 to 13.3.2 (#116)

Bumps [multiformats](https://github.com/multiformats/js-multiformats) from 13.3.1 to 13.3.2.
- [Release notes](https://github.com/multiformats/js-multiformats/releases)
- [Changelog](https://github.com/multiformats/js-multiformats/blob/master/CHANGELOG.md)
- [Commits](multiformats/js-multiformats@v13.3.1...v13.3.2)

---
updated-dependencies:
- dependency-name: multiformats
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: add auto approve minor `multiformats` updates (#125)

* deps(dev): bump @types/node from 22.13.4 to 22.13.5 (#127)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.13.4 to 22.13.5.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* deps(dev): bump prettier from 3.5.1 to 3.5.2 (#128)

Bumps [prettier](https://github.com/prettier/prettier) from 3.5.1 to 3.5.2.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.5.1...3.5.2)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* deps: bump @sentry/node from 9.1.0 to 9.2.0 (#129)

Bumps [@sentry/node](https://github.com/getsentry/sentry-javascript) from 9.1.0 to 9.2.0.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/develop/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@9.1.0...9.2.0)

---
updated-dependencies:
- dependency-name: "@sentry/node"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: support for `http-path` multiaddr (#131)

* copied mutliaddr func

* add test for malformed http-path address

* formatting

* fmt

* fmt

---------

Co-authored-by: Nikolas Haimerl <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Co-authored-by: Julian Gruber <[email protected]>
Co-authored-by: Miroslav Bajtoš <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nikolas Haimerl <[email protected]>
Co-authored-by: Nikolas Haimerl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliangruber juliangruber juliangruber approved these changes

@bajtos bajtos Awaiting requested review from bajtos bajtos is a code owner

@pyropy pyropy Awaiting requested review from pyropy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikolasHaimerl @juliangruber