Skip to content

chore: add dist folder to release #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: add dist folder to release #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"lint": "eslint && prettier --check .",
"lint:fix": "eslint --fix && prettier . --write",
"test": "npm run lint && npm run test:types && npm run test:unit",
"release": "np"
"release": "tsc -p . && git add dist && np"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually don't commit auto-generated files. (The vendor directory in spark-checker is an exception for good reasons.)

By default, npm excludes all files listed in .gitignore. Instead of adding dist to git, you should tell npm to include it in the package.

See how we do that in our other repositories:

https://github.com/CheckerNetwork/assert-ok-response/blob/bff5c4861e3a64e262b08bba370c6480b597c116/package.json#L25-L28

https://github.com/CheckerNetwork/node/blob/1eb60459f0c27327044de3a02d61757657d2087f/package.json#L65-L71

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also #14 (comment)

},
"repository": {
"type": "git",
Expand Down