chore: add dist folder to release #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
requested changes
Apr 4, 2025
| @@ -10,7 +10,7 @@ | |||
| "lint": "eslint && prettier --check .", | |||
| "lint:fix": "eslint --fix && prettier . --write", | |||
| "test": "npm run lint && npm run test:types && npm run test:unit", | |||
| "release": "np" | |||
| "release": "tsc -p . && git add dist && np" | |||
There was a problem hiding this comment.
We usually don't commit auto-generated files. (The vendor directory in spark-checker is an exception for good reasons.)
By default, npm excludes all files listed in .gitignore. Instead of adding dist to git, you should tell npm to include it in the package.
See how we do that in our other repositories:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes subtask of #14