Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added basic sim function to refactor #3

Merged
merged 11 commits into from
Nov 12, 2024
Merged

added basic sim function to refactor #3

merged 11 commits into from
Nov 12, 2024

Conversation

TiaSinghania
Copy link

What type of PR is this? (check all applicable)

  • Refactor
  • [X ] Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Added engine code, translated to ros 2, added command line args

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • [X ] Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

alt_text

Copy link

@mehulgoel873 mehulgoel873 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finish up the changes I asked for and add a page to the wiki


def __init__(self):
super().__init__('sim_single')
self.get_logger().info('INITIALIZED.')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initialized what?

"RACELINE_PASS": (589468.02, 4476993.07, -160),
}

self.number_publisher = self.create_publisher(Float64, 'numbers', 1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete

Float64, "buggy/input/steering", self.update_steering_angle, 1
)
# To read from velocity
self.velocity_subscriber = self.create_subscription(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sim/velocity

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate engine


if (self.get_namespace() == "/NAND"):
self.buggy_name = "NAND"
self.declare_parameter('pose', "Hill1_NAND")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is delcare parameter mean?

@mehulgoel873 mehulgoel873 merged commit 0800563 into main Nov 12, 2024
3 checks passed
@mehulgoel873 mehulgoel873 deleted the sim-rewrite branch November 12, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants