Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path planner #14

Merged
merged 16 commits into from
Jan 11, 2025
Merged

Path planner #14

merged 16 commits into from
Jan 11, 2025

Conversation

mehulgoel873
Copy link

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Describe the CHANGES, the REASONING, and BENEFITS of this PR.

CHANGES - The path planner was separated from controller, new package structure, etc.
REASONING - Everything was a pain beforehand
BENEFITS - We have a working path planner

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

alt_text

@mehulgoel873 mehulgoel873 self-assigned this Jan 8, 2025
Dockerfile Outdated Show resolved Hide resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this file required to have in a package?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed package to be C based with python as an add-on, not necessary anymore

@mehulgoel873 mehulgoel873 merged commit 07d062c into main Jan 11, 2025
0 of 3 checks passed
@mehulgoel873 mehulgoel873 deleted the path_plan branch January 11, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants