forked from CMU-Robotics-Club/RoboBuggy2
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path planner #14
Merged
Merged
Path planner #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rk012
reviewed
Jan 9, 2025
TiaSinghania
reviewed
Jan 9, 2025
rb_ws/src/buggy/setup.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this file required to have in a package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed package to be C based with python as an add-on, not necessary anymore
TiaSinghania
reviewed
Jan 9, 2025
TiaSinghania
reviewed
Jan 9, 2025
TiaSinghania
reviewed
Jan 9, 2025
TiaSinghania
reviewed
Jan 9, 2025
TiaSinghania
reviewed
Jan 9, 2025
TiaSinghania
reviewed
Jan 9, 2025
TiaSinghania
reviewed
Jan 9, 2025
TiaSinghania
reviewed
Jan 9, 2025
saransh323
reviewed
Jan 10, 2025
TiaSinghania
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Describe the CHANGES, the REASONING, and BENEFITS of this PR.
CHANGES - The path planner was separated from controller, new package structure, etc.
REASONING - Everything was a pain beforehand
BENEFITS - We have a working path planner
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
have not been included
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?