[WIP] Refactor usage of connectivity and neighbor_table for consistency#1184
Draft
[WIP] Refactor usage of connectivity and neighbor_table for consistency#1184
Conversation
|
Hi there, this is jenkins continuous integration... |
1 similar comment
|
Hi there, this is jenkins continuous integration... |
Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/01faaff7-7d25-450e-a63d-feb902ead295 Co-authored-by: jcanton <5622559+jcanton@users.noreply.github.com>
Copilot stopped work on behalf of
jcanton due to an error
March 30, 2026 10:37
Contributor
|
I would discuss the naming convention first... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connectivities→neighbor_tablesinhalo.py(IconLikeHaloConstructorinit param,self._connectivitiesfield,_connectivitymethod,get_halo_constructorparam) since these store raw NDArrays_get_local_connectivities→_get_local_neighbor_tablesingrid_manager.py_get_derived_connectivities→_get_derived_neighbor_tablesingrid_manager.pygrid_manager.pywhereconnectivities=global_neighbor_tablesis passed toget_halo_constructorbase.py::_replace_skip_valueswhere Args saysconnectivity:but param isneighbor_tabletest_halo.py,test_parallel_halo.py)